Skip to content

[libc] fix lfind entrypoints #115771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

nickdesaulniers
Copy link
Member

  • move arm entrypoint to fullbuild only
  • remove baremetal entrypoints; we avoid POSIX on baremetal
  • remove darwin/arm and windows entrypoints since these are untested

Fixes: #114692

- move arm entrypoint to fullbuild only
- remove baremetal entrypoints; we avoid POSIX on baremetal
- remove darwin/arm and windows entrypoints since these are untested

Fixes: llvm#114692
@llvmbot
Copy link
Member

llvmbot commented Nov 11, 2024

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes
  • move arm entrypoint to fullbuild only
  • remove baremetal entrypoints; we avoid POSIX on baremetal
  • remove darwin/arm and windows entrypoints since these are untested

Fixes: #114692


Full diff: https://github.com/llvm/llvm-project/pull/115771.diff

5 Files Affected:

  • (modified) libc/config/baremetal/arm/entrypoints.txt (-3)
  • (modified) libc/config/baremetal/riscv/entrypoints.txt (-3)
  • (modified) libc/config/darwin/arm/entrypoints.txt (-3)
  • (modified) libc/config/linux/arm/entrypoints.txt (+3-3)
  • (modified) libc/config/windows/entrypoints.txt (-3)
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index f59208deba614c..b85ae1119345dd 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -26,9 +26,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind
-
     # setjmp.h entrypoints
     libc.src.setjmp.longjmp
     libc.src.setjmp.setjmp
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index e59c4e843e5d5c..199a030ee6371e 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -26,9 +26,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy
diff --git a/libc/config/darwin/arm/entrypoints.txt b/libc/config/darwin/arm/entrypoints.txt
index 13860015ae5841..2d5dbeff485747 100644
--- a/libc/config/darwin/arm/entrypoints.txt
+++ b/libc/config/darwin/arm/entrypoints.txt
@@ -20,9 +20,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind 
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy
diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index b4f08cde6df48a..31d81de06fb6b0 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -20,9 +20,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     # errno.h entrypoints
     libc.src.errno.errno
 
-    # search.h entrypoints
-    libc.src.search.lfind  
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy
@@ -186,6 +183,9 @@ set(TARGET_LIBC_ENTRYPOINTS
 
 if(LLVM_LIBC_FULL_BUILD)
   list(APPEND TARGET_LIBC_ENTRYPOINTS
+    # search.h entrypoints
+    libc.src.search.lfind
+
     # setjmp.h entrypoints
     libc.src.setjmp.longjmp
     libc.src.setjmp.setjmp
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index 5ffd32373148cd..8f0b50bcc83ea2 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -17,9 +17,6 @@ set(TARGET_LIBC_ENTRYPOINTS
     libc.src.ctype.tolower
     libc.src.ctype.toupper
 
-    # search.h entrypoints
-    libc.src.search.lfind
-
     # string.h entrypoints
     libc.src.string.bcmp
     libc.src.string.bcopy

@nickdesaulniers nickdesaulniers merged commit f1800df into llvm:main Nov 11, 2024
7 of 8 checks passed
@nickdesaulniers nickdesaulniers deleted the fixup_lfind branch November 11, 2024 21:38
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
- move arm entrypoint to fullbuild only
- remove baremetal entrypoints; we avoid POSIX on baremetal
- remove darwin/arm and windows entrypoints since these are untested

Fixes: llvm#114692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants