Skip to content

[llvm-profdata] fix typo #116754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[llvm-profdata] fix typo #116754

merged 1 commit into from
Nov 20, 2024

Conversation

lifengxiang1025
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the PGO Profile Guided Optimizations label Nov 19, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 19, 2024

@llvm/pr-subscribers-pgo

Author: None (lifengxiang1025)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/116754.diff

1 Files Affected:

  • (modified) llvm/tools/llvm-profdata/llvm-profdata.cpp (+1-1)
diff --git a/llvm/tools/llvm-profdata/llvm-profdata.cpp b/llvm/tools/llvm-profdata/llvm-profdata.cpp
index 8a42e430fb54e8..dcc8609f8df942 100644
--- a/llvm/tools/llvm-profdata/llvm-profdata.cpp
+++ b/llvm/tools/llvm-profdata/llvm-profdata.cpp
@@ -375,7 +375,7 @@ cl::opt<unsigned long long> OverlapValueCutoff(
     cl::desc(
         "Function level overlap information for every function (with calling "
         "context for csspgo) in test "
-        "profile with max count value greater then the parameter value"),
+        "profile with max count value greater than the parameter value"),
     cl::sub(OverlapSubcommand));
 
 // Options specific to show subcommand.

@lifengxiang1025 lifengxiang1025 merged commit 314e9b1 into llvm:main Nov 20, 2024
7 of 10 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 20, 2024

LLVM Buildbot has detected a new failure on builder clang-cmake-x86_64-avx512-linux running on avx512-intel64 while building llvm at step 13 "test-suite".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/7088

Here is the relevant piece of the build log for the reference
Step 13 (test-suite) failure: test (failure)
...
    result = litsupport.testplan.executePlanTestResult(context, plan)
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/litsupport/testplan.py", line 160, in executePlanTestResult
    result_code = _executePlan(context, testplan)
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/litsupport/testplan.py", line 110, in _executePlan
    _, _, exitCode, _ = _executeScript(context, plan.verifyscript, "verify")
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/litsupport/testplan.py", line 61, in _executeScript
    logging.info("\n".join(script))
Message: '/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/tools/HashProgramOutput.sh /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/SingleSource/Benchmarks/Polybench/medley/floyd-warshall/Output/floyd-warshall.test.out\n/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/tools/fpcmp-target /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/SingleSource/Benchmarks/Polybench/medley/floyd-warshall/Output/floyd-warshall.test.out /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/SingleSource/Benchmarks/Polybench/medley/floyd-warshall/floyd-warshall.reference_output'
Arguments: ()
UNRESOLVED: test-suite :: SingleSource/Benchmarks/Polybench/medley/floyd-warshall/floyd-warshall.test (2519 of 2519)
******************** TEST 'test-suite :: SingleSource/Benchmarks/Polybench/medley/floyd-warshall/floyd-warshall.test' FAILED ********************
Exception during script execution:
OSError: [Errno 28] No space left on device

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/utils/lit/lit/worker.py", line 76, in _execute_test_handle_errors
    result = test.config.test_format.execute(test, lit_config)
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/litsupport/test.py", line 71, in execute
    result = litsupport.testplan.executePlanTestResult(context, plan)
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/litsupport/testplan.py", line 160, in executePlanTestResult
    result_code = _executePlan(context, testplan)
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/litsupport/testplan.py", line 110, in _executePlan
    _, _, exitCode, _ = _executeScript(context, plan.verifyscript, "verify")
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/litsupport/testplan.py", line 62, in _executeScript
    res = executeFunc(
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/utils/lit/lit/TestRunner.py", line 1277, in executeScript
    f.close()
OSError: [Errno 28] No space left on device


********************
llvm-lit: /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/utils/lit/lit/TestTimes.py:39: warning: Could not save test time: /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/build/.lit_test_times.txt
********************
Unresolved Tests (1):
  test-suite :: SingleSource/Benchmarks/Polybench/medley/floyd-warshall/floyd-warshall.test


Testing Time: 296.72s

Total Discovered Tests: 2519
  Passed    : 2518 (99.96%)
  Unresolved:    1 (0.04%)
Traceback (most recent call last):
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/stage1/bin/llvm-lit", line 47, in <module>
    main(builtin_parameters)
  File "/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/llvm/llvm/utils/lit/lit/main.py", line 145, in main
    report.write_results(tests_for_report, elapsed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PGO Profile Guided Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants