[mlir][llvm] support -new-struct-path-tbaa #119698

PikachuHyA · 2024-12-12T13:01:10Z

This patch introduces attributes such as LLVM_TBAAStructFieldAttr, LLVM_TBAATypeNodeAttr, and LLVM_TBAAAccessTagAttr that are specifically designed to handle the new struct path TBAA.

llvmbot · 2024-12-12T13:01:46Z

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-llvm

Author: PikachuHy (PikachuHyA)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/119698.diff

5 Files Affected:

(modified) mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td (+77-1)
(modified) mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h (+1-1)
(modified) mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp (+2-1)
(modified) mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp (+9-1)
(modified) mlir/lib/Target/LLVMIR/ModuleTranslation.cpp (+36-2)

diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
index e8eeafd09a9cba..198e1f8982ef14 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
@@ -1080,8 +1080,84 @@ def LLVM_TBAATagAttr : LLVM_Attr<"TBAATag", "tbaa_tag"> {
   let assemblyFormat = "`<` struct(params) `>`";
 }
 
+def LLVM_TBAAStructFieldAttr : LLVM_Attr<"TBAAStructField", "tbaa_struct_field"> {
+  let parameters = (ins
+    "TBAANodeAttr":$typeDesc,
+    "int64_t":$offset,
+    "int64_t":$size
+  );
+  let assemblyFormat = "`<` struct(params) `>`";
+}
+
+
+def LLVM_TBAAStructFieldAttrArray : ArrayRefParameter<"TBAAStructFieldAttr"> {
+  let printer = [{
+    $_printer << '{';
+    llvm::interleaveComma($_self, $_printer, [&](TBAAStructFieldAttr attr) {
+        $_printer.printStrippedAttrOrType(attr);
+    });
+    $_printer << '}';
+  }];
+
+  let parser = [{
+    [&]() -> FailureOr<SmallVector<TBAAStructFieldAttr>> {
+        using Result = SmallVector<TBAAStructFieldAttr>;
+        if ($_parser.parseLBrace())
+            return failure();
+        FailureOr<Result> result = FieldParser<Result>::parse($_parser);
+        if (failed(result))
+            return failure();
+        if ($_parser.parseRBrace())
+            return failure();
+        return result;
+    }()
+  }];
+}
+
+def LLVM_TBAATypeNodeAttr : LLVM_Attr<"TBAATypeNode", "tbaa_type_node", [], "TBAANodeAttr"> {
+  let parameters = (ins
+    "TBAANodeAttr":$parent,
+    "int64_t":$size,
+    StringRefParameter<>:$id,
+    LLVM_TBAAStructFieldAttrArray:$fields
+  );
+  let assemblyFormat = "`<` struct(params) `>`";
+}
+
+def LLVM_TBAAAccessTagAttr : LLVM_Attr<"TBAAAccessTag", "tbaa_access_tag"> {
+  let parameters = (ins
+    "TBAATypeNodeAttr":$base_type,
+    "TBAATypeNodeAttr":$access_type,
+    "int64_t":$offset,
+    "int64_t":$size
+  );
+  let builders = [
+    AttrBuilderWithInferredContext<(ins "TBAATypeNodeAttr":$baseType,
+                                        "TBAATypeNodeAttr":$accessType,
+                                        "int64_t":$offset,
+                                        "int64_t":$size), [{
+      return $_get(baseType.getContext(), baseType, accessType, offset, size);
+    }]>
+  ];
+  let assemblyFormat = "`<` struct(params) `>`";
+}
+
+def LLVM_TBAAAccessTagArrayAttr
+    : TypedArrayAttrBase<LLVM_TBAAAccessTagAttr,
+                         LLVM_TBAAAccessTagAttr.summary # " array"> {
+  let constBuilderCall = ?;
+}
+
+// def LLVM_TBAATagAttr2 : AnyAttrOf<[
+//   LLVM_TBAATagAttr,
+//   LLVM_TBAAAccessTagAttr
+// ]>;
+
 def LLVM_TBAATagArrayAttr
-    : TypedArrayAttrBase<LLVM_TBAATagAttr,
+    : TypedArrayAttrBase<AnyAttrOf<[
+  LLVM_TBAATagAttr,
+  LLVM_TBAAAccessTagAttr
+]>,
                          LLVM_TBAATagAttr.summary # " array"> {
   let constBuilderCall = ?;
 }
diff --git a/mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h b/mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h
index ffeeeae57ae952..c7a79aa330d3da 100644
--- a/mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h
+++ b/mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h
@@ -323,7 +323,7 @@ class ModuleTranslation {
 
   /// Returns the LLVM metadata corresponding to the given mlir LLVM dialect
   /// TBAATagAttr.
-  llvm::MDNode *getTBAANode(TBAATagAttr tbaaAttr) const;
+  llvm::MDNode *getTBAANode(Attribute tbaaAttr) const;
 
   /// Process tbaa LLVM Metadata operations and create LLVM
   /// metadata nodes for them.
diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
index 6b2d8943bf4885..b2b0b9b331e0b4 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
@@ -3401,7 +3401,8 @@ struct LLVMOpAsmDialectInterface : public OpAsmDialectInterface {
               LoopVectorizeAttr, LoopInterleaveAttr, LoopUnrollAttr,
               LoopUnrollAndJamAttr, LoopLICMAttr, LoopDistributeAttr,
               LoopPipelineAttr, LoopPeeledAttr, LoopUnswitchAttr, TBAARootAttr,
-              TBAATagAttr, TBAATypeDescriptorAttr>([&](auto attr) {
+              TBAATagAttr, TBAATypeDescriptorAttr, TBAAAccessTagAttr,
+              TBAATypeNodeAttr>([&](auto attr) {
           os << decltype(attr)::getMnemonic();
           return AliasResult::OverridableAlias;
         })
diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp
index cff16afc73af3f..6a9395b1f4a26e 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp
@@ -58,7 +58,15 @@ mlir::LLVM::detail::verifyAliasAnalysisOpInterface(Operation *op) {
   ArrayAttr tags = iface.getTBAATagsOrNull();
   if (!tags)
     return success();
-
+  if (tags.size() > 0) {
+    if (mlir::isa<TBAATagAttr>(tags[0])) {
+      return isArrayOf<TBAATagAttr>(op, tags);
+    }
+
+    if (mlir::isa<TBAAAccessTagAttr>(tags[0])) {
+      return isArrayOf<TBAAAccessTagAttr>(op, tags);
+    }
+  }
   return isArrayOf<TBAATagAttr>(op, tags);
 }
 
diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index ceb8ba3b33818b..6a6c29869ba805 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -1766,7 +1766,8 @@ void ModuleTranslation::setAliasScopeMetadata(AliasAnalysisOpInterface op,
                         llvm::LLVMContext::MD_noalias);
 }
 
-llvm::MDNode *ModuleTranslation::getTBAANode(TBAATagAttr tbaaAttr) const {
+// llvm::MDNode *ModuleTranslation::getTBAANode(TBAATagAttr tbaaAttr) const {
+llvm::MDNode *ModuleTranslation::getTBAANode(Attribute tbaaAttr) const {
   return tbaaMetadataMapping.lookup(tbaaAttr);
 }
 
@@ -1786,7 +1787,8 @@ void ModuleTranslation::setTBAAMetadata(AliasAnalysisOpInterface op,
     return;
   }
 
-  llvm::MDNode *node = getTBAANode(cast<TBAATagAttr>(tagRefs[0]));
+  // llvm::MDNode *node = getTBAANode(cast<TBAATagAttr>(tagRefs[0]));
+  llvm::MDNode *node = getTBAANode(tagRefs[0]);
   inst->setMetadata(llvm::LLVMContext::MD_tbaa, node);
 }
 
@@ -1806,6 +1808,7 @@ void ModuleTranslation::setBranchWeightsMetadata(BranchWeightOpInterface op) {
 LogicalResult ModuleTranslation::createTBAAMetadata() {
   llvm::LLVMContext &ctx = llvmModule->getContext();
   llvm::IntegerType *offsetTy = llvm::IntegerType::get(ctx, 64);
+  llvm::IntegerType *sizeTy = llvm::IntegerType::get(ctx, 64);
 
   // Walk the entire module and create all metadata nodes for the TBAA
   // attributes. The code below relies on two invariants of the
@@ -1833,6 +1836,23 @@ LogicalResult ModuleTranslation::createTBAAMetadata() {
     tbaaMetadataMapping.insert({descriptor, llvm::MDNode::get(ctx, operands)});
   });
 
+  walker.addWalk([&](TBAATypeNodeAttr descriptor) {
+    SmallVector<llvm::Metadata *> operands;
+    operands.push_back(tbaaMetadataMapping.lookup(descriptor.getParent()));
+    operands.push_back(llvm::ConstantAsMetadata::get(
+        llvm::ConstantInt::get(sizeTy, descriptor.getSize())));
+    operands.push_back(llvm::MDString::get(ctx, descriptor.getId()));
+    for (auto field : descriptor.getFields()) {
+      operands.push_back(tbaaMetadataMapping.lookup(field.getTypeDesc()));
+      operands.push_back(llvm::ConstantAsMetadata::get(
+          llvm::ConstantInt::get(offsetTy, field.getOffset())));
+      operands.push_back(llvm::ConstantAsMetadata::get(
+          llvm::ConstantInt::get(sizeTy, field.getSize())));
+    }
+
+    tbaaMetadataMapping.insert({descriptor, llvm::MDNode::get(ctx, operands)});
+  });
+
   walker.addWalk([&](TBAATagAttr tag) {
     SmallVector<llvm::Metadata *> operands;
 
@@ -1848,6 +1868,20 @@ LogicalResult ModuleTranslation::createTBAAMetadata() {
     tbaaMetadataMapping.insert({tag, llvm::MDNode::get(ctx, operands)});
   });
 
+  walker.addWalk([&](TBAAAccessTagAttr tag) {
+    SmallVector<llvm::Metadata *> operands;
+
+    operands.push_back(tbaaMetadataMapping.lookup(tag.getBaseType()));
+    operands.push_back(tbaaMetadataMapping.lookup(tag.getAccessType()));
+
+    operands.push_back(llvm::ConstantAsMetadata::get(
+        llvm::ConstantInt::get(offsetTy, tag.getOffset())));
+    operands.push_back(llvm::ConstantAsMetadata::get(
+        llvm::ConstantInt::get(sizeTy, tag.getSize())));
+
+    tbaaMetadataMapping.insert({tag, llvm::MDNode::get(ctx, operands)});
+  });
+
   mlirModule->walk([&](AliasAnalysisOpInterface analysisOpInterface) {
     if (auto attr = analysisOpInterface.getTBAATagsOrNull())
       walker.walk(attr);

PikachuHyA · 2025-02-25T09:07:38Z

cc @bcardosolopes

gysit

Thanks!

The direction looks good.

With regards to the attribute names are they derived from LLVM? Does the new format somehow have a name that we could potentially use to prefix/postfix things. The names Tag and AccessTag for almost the same thing are a bit confusing.

For now I mostly looked at the attribute definitions. Once they are set it may make sense to proceed with some tests similar to:

tbaa-rountrip.mlir
tbaa-invalid.mlir
In addition, some export tests will make sense as well.

gysit · 2025-02-25T19:20:11Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+  }];
+}
+
+def LLVM_TBAATypeNodeAttr : LLVM_Attr<"TBAATypeNode", "tbaa_type_node", [], "TBAANodeAttr"> {


I believe if the class should derive from TBAANodeAttr it also needs to be added here:

llvm-project/mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp

Line 129 in 9102afc

return llvm::isa<TBAATypeDescriptorAttr, TBAARootAttr>(attr);

gysit · 2025-02-25T19:29:26Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

@@ -1084,8 +1084,79 @@ def LLVM_TBAATagAttr : LLVM_Attr<"TBAATag", "tbaa_tag"> {
  let assemblyFormat = "`<` struct(params) `>`";
 }

+def LLVM_TBAAStructFieldAttr : LLVM_Attr<"TBAAStructField", "tbaa_struct_field"> {


Suggested change

def LLVM_TBAAStructFieldAttr : LLVM_Attr<"TBAAStructField", "tbaa_struct_field"> {

//===----------------------------------------------------------------------===//

// TBAAStructFieldAttr

//===----------------------------------------------------------------------===//

def LLVM_TBAAStructFieldAttr : LLVM_Attr<"TBAAStructField", "tbaa_struct_field"> {

nit: let's use banners to structure the file a bit.

gysit · 2025-02-25T19:30:59Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+    "int64_t":$offset,
+    "int64_t":$size
+  );
+  let assemblyFormat = "`<` struct(params) `>`";


Can you use let description / let summary to provide some doc/examples for the relevant attributes.

gysit · 2025-02-25T19:37:38Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+
+def LLVM_TBAATypeNodeAttr : LLVM_Attr<"TBAATypeNode", "tbaa_type_node", [], "TBAANodeAttr"> {
+  let parameters = (ins
+    "TBAANodeAttr":$parent,


Are new and old format mixed? Or in other words can this be a TBAATypeDescriptorAttr? If not we may want to have an attribute verifier that ensures the parent is either a root or another LLVM_TBAATypeNodeAttr.

Are new and old format mixed? Or in other words can this be a TBAATypeDescriptorAttr?

No.
The only other TBAANodeAttr used by LLVM_TBAATypeNodeAttr is LLVM_TBAARootAttr.

Makes sense.

If we want to verify this we have sort of two options:

we add a verifier to attribute that checks that parent is not a TBAATypeDescriptorAttr.

We implement a separate base class for the new TBBAA format which could be called TBAAAccessNodeAttr if we follow the naming scheme of the access tag. However, this also requires
a TBAAAccessRootAttr since an attribute can only inherit from one base class AFAIK.

I do not have a clear preference.

gysit · 2025-02-25T20:02:25Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+    "TBAATypeNodeAttr":$base_type,
+    "TBAATypeNodeAttr":$access_type,
+    "int64_t":$offset,
+    "int64_t":$size


It feels like the difference to TBAATagAttr is minimal (i.e mainly the size). However, I guess it still makes sense to separate them.

Another option is to add an optional "int64_t": $size in TBAATagAttr . However, this approach carries the risk of mixing the old and new formats.

I think given LLVM proper has a counter part and since the two TBAA variants cannot be mixed, I am actually in favor of having a separate LLVM_TBAAAccessTagAttr!

gysit · 2025-02-25T20:04:08Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+  let assemblyFormat = "`<` struct(params) `>`";
+}
+
+def LLVM_TBAAAccessTagArrayAttr


Is this used?

no.

The array of LLVM_TBAAAccessTagAttr is used by the following definition:

def LLVM_TBAATagArrayAttr : TypedArrayAttrBase<AnyAttrOf<[ LLVM_TBAATagAttr, LLVM_TBAAAccessTagAttr ]>

Therefore, the LLVM_TBAAAccessTagArrayAttr is no longer needed.

gysit · 2025-02-25T20:05:19Z

mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp

@@ -58,7 +58,15 @@ mlir::LLVM::detail::verifyAliasAnalysisOpInterface(Operation *op) {
  ArrayAttr tags = iface.getTBAATagsOrNull();
  if (!tags)
    return success();
-
+  if (tags.size() > 0) {


Shouldn't it just be:
return isArrayOf<TBAATagAttr>(op, tags) || isArrayOf<TBAAAccessTagAttr>(op, tags);

The isArrayOf<xxx> reports an error if any element in the provided array is not type of xxx.
and the result type LogicalResult dose not support the || operator.

/// Verifies that all elements of `array` are instances of `Attr`. template <class AttrT> static LogicalResult isArrayOf(Operation *op, ArrayAttr array) { for (Attribute iter : array) if (!isa<AttrT>(iter)) return op->emitOpError("expected op to return array of ") << AttrT::getMnemonic() << " attributes"; return success(); }

see
https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp#L19-L27

Ok I understand. I would suggest to extend the AliasAnalysisOpInterface. It currently has one function that returns the TBAA tags. How about implementing two functions:

iface.getTBBATagsOrNull()

and

iface.getTBBAAccessTagsOrNull()

This could potentially be implemented by having two arrays stored on the alias operations. Or by checking if the array contains the old or the new kind of TBAA attributes. That way the verifier can use the existing logic for the two cases separately. And to users of the exiting TBAA attributes don't need to understand the new kind of TBAA metadata.

WDYT?

gysit · 2025-02-25T20:23:38Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+}
+
+
+def LLVM_TBAAStructFieldAttrArray : ArrayRefParameter<"TBAAStructFieldAttr"> {


I wonder why we implemented our own array attributes at the time. @vzakhari do you remember? Potentially we could just use:
OptionalArrayRefParameter<"TBAAStructFieldAttr">:$fields
In LLVM_TBAATypeNodeAttr.

Sorry, I do not remember. It would probably work either way.

@PikachuHyA It is quite a lot of custom printing / parsing that could be saved with OptionalArrayRefParameter<"TBAAStructFieldAttr">:$fields. So maybe we want to give it a shot.

PikachuHyA · 2025-02-27T12:54:59Z

hi @gysit , thanks for your comments.

I've encountered a crash, so I need more time to troubleshoot the issue.

With regards to the attribute names are they derived from LLVM?

Regarding your question about the attribute names: they are derived from function names and class name in CodeGenTBAA.cpp

the name of TBAATypeNode is from

the name of TBAAAccessTag is from

https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenTBAA.cpp#L636-L639

the name of TBAAStructField is from

https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenTBAA.cpp#L508-L513

gysit

Thanks for the naming link. I believe it makes sense to follow this naming convention then. I would have liked some consistent prefix such as TBAA_NEW_tag, TBAA_NEW_type_descriptor etc. But then it is probably unclear what a good choice for NEW would be. In any case, we should stick to what LLVM uses.

gysit · 2025-02-27T18:26:13Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+    "TBAATypeNodeAttr":$base_type,
+    "TBAATypeNodeAttr":$access_type,
+    "int64_t":$offset,
+    "int64_t":$size


I think given LLVM proper has a counter part and since the two TBAA variants cannot be mixed, I am actually in favor of having a separate LLVM_TBAAAccessTagAttr!

gysit · 2025-02-27T18:32:49Z

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

+
+def LLVM_TBAATypeNodeAttr : LLVM_Attr<"TBAATypeNode", "tbaa_type_node", [], "TBAANodeAttr"> {
+  let parameters = (ins
+    "TBAANodeAttr":$parent,


Makes sense.

If we want to verify this we have sort of two options:

we add a verifier to attribute that checks that parent is not a TBAATypeDescriptorAttr.

We implement a separate base class for the new TBBAA format which could be called TBAAAccessNodeAttr if we follow the naming scheme of the access tag. However, this also requires
a TBAAAccessRootAttr since an attribute can only inherit from one base class AFAIK.

I do not have a clear preference.

gysit · 2025-02-27T18:47:35Z

mlir/lib/Dialect/LLVMIR/IR/LLVMInterfaces.cpp

@@ -58,7 +58,15 @@ mlir::LLVM::detail::verifyAliasAnalysisOpInterface(Operation *op) {
  ArrayAttr tags = iface.getTBAATagsOrNull();
  if (!tags)
    return success();
-
+  if (tags.size() > 0) {


Ok I understand. I would suggest to extend the AliasAnalysisOpInterface. It currently has one function that returns the TBAA tags. How about implementing two functions:

iface.getTBBATagsOrNull()

and

iface.getTBBAAccessTagsOrNull()

This could potentially be implemented by having two arrays stored on the alias operations. Or by checking if the array contains the old or the new kind of TBAA attributes. That way the verifier can use the existing logic for the two cases separately. And to users of the exiting TBAA attributes don't need to understand the new kind of TBAA metadata.

WDYT?

PikachuHyA marked this pull request as draft December 12, 2024 13:01

llvmbot added mlir:llvm mlir labels Dec 12, 2024

PikachuHyA mentioned this pull request Dec 12, 2024

support new struct path tbaa in MLIR LLVM Dialect #119699

Open

PikachuHyA force-pushed the mlir_llvm_new_struct_path branch from 0db13b8 to a18a074 Compare February 25, 2025 06:20

PikachuHyA marked this pull request as ready for review February 25, 2025 06:21

PikachuHyA changed the title ~~[WIP][mlir][llvm] support new-struct-path-tbaa~~ [mlir][llvm] support new-struct-path-tbaa Feb 25, 2025

PikachuHyA changed the title ~~[mlir][llvm] support new-struct-path-tbaa~~ [mlir][llvm] support -new-struct-path-tbaa Feb 25, 2025

PikachuHyA mentioned this pull request Feb 25, 2025

[WIP][CIR][CIRGen][TBAA] Add support for -new-struct-path-tbaa llvm/clangir#1403

Open

[mlir][llvm] support new-struct-path-tbaa

df5635f

PikachuHyA force-pushed the mlir_llvm_new_struct_path branch from a18a074 to df5635f Compare February 25, 2025 09:11

gysit reviewed Feb 25, 2025

View reviewed changes

gysit reviewed Feb 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mlir][llvm] support -new-struct-path-tbaa #119698

[mlir][llvm] support -new-struct-path-tbaa #119698

PikachuHyA commented Dec 12, 2024 •

edited

Loading

llvmbot commented Dec 12, 2024 •

edited

Loading

PikachuHyA commented Feb 25, 2025

gysit left a comment

gysit Feb 25, 2025

gysit Feb 25, 2025

gysit Feb 25, 2025

gysit Feb 25, 2025

PikachuHyA Feb 27, 2025

gysit Feb 27, 2025

gysit Feb 25, 2025

PikachuHyA Feb 27, 2025

gysit Feb 27, 2025

gysit Feb 25, 2025

PikachuHyA Feb 27, 2025

PikachuHyA Feb 27, 2025

gysit Feb 25, 2025

PikachuHyA Feb 27, 2025

gysit Feb 27, 2025

gysit Feb 25, 2025

vzakhari Feb 27, 2025

gysit Feb 28, 2025

PikachuHyA commented Feb 27, 2025

gysit left a comment

gysit Feb 27, 2025

gysit Feb 27, 2025

gysit Feb 27, 2025

-def LLVM_TBAAStructFieldAttr : LLVM_Attr<"TBAAStructField", "tbaa_struct_field"> {
+//===----------------------------------------------------------------------===//
+// TBAAStructFieldAttr
+//===----------------------------------------------------------------------===//
+def LLVM_TBAAStructFieldAttr : LLVM_Attr<"TBAAStructField", "tbaa_struct_field"> {

		}


		def LLVM_TBAAStructFieldAttrArray : ArrayRefParameter<"TBAAStructFieldAttr"> {

[mlir][llvm] support -new-struct-path-tbaa #119698

Are you sure you want to change the base?

[mlir][llvm] support -new-struct-path-tbaa #119698

Conversation

PikachuHyA commented Dec 12, 2024 • edited Loading

llvmbot commented Dec 12, 2024 • edited Loading

PikachuHyA commented Feb 25, 2025

gysit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PikachuHyA commented Feb 27, 2025

gysit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PikachuHyA commented Dec 12, 2024 •

edited

Loading

llvmbot commented Dec 12, 2024 •

edited

Loading