Skip to content

[CodeGen] Add MOTargetFlag4 to MachineMemOperand Flags #120136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

[CodeGen] Add MOTargetFlag4 to MachineMemOperand Flags #120136

merged 1 commit into from
Jan 3, 2025

Conversation

Acim-Maravic
Copy link
Contributor

No description provided.

@Acim-Maravic Acim-Maravic requested a review from jayfoad December 16, 2024 20:18
jayfoad
jayfoad reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding another target flag seems uncontroversial. Does the MIR parsing code need to be updated as well as the printer?

@Acim-Maravic
Copy link
Contributor Author

Adding another target flag seems uncontroversial. Does the MIR parsing code need to be updated as well as the printer?

The MIR parsing code does not need to be updated. I will add a test example in target-memoperands.mir when I add support for targetflag.

@Acim-Maravic Acim-Maravic merged commit 9d6527b into llvm:main Jan 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayfoad jayfoad jayfoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acim-Maravic @jayfoad