MIPS: Adding a check for JAL argument in PIC mode to prevent crashing on getExpr #120356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@wzssyqa could you please take a look? |
wzssyqa
changed the title
wzssyqa
reviewed
Dec 20, 2024
| @@ -2108,6 +2108,10 @@ bool MipsAsmParser::processInstruction(MCInst &Inst, SMLoc IDLoc, | |||
| if ((Opcode == Mips::JAL || Opcode == Mips::JAL_MM) && inPicMode()) { | |||
| warnIfNoMacro(IDLoc); | |||
|
|
|||
| if (!Inst.getOperand(0).isExpr()) { | |||
| return Error(IDLoc, "jal needs a symbolic expression in PIC mode"); | |||
There was a problem hiding this comment.
gas gives the error message like:
k.s: Assembler messages:
k.s:2: Error: unsupported constant in relocation
I think that we should keep them same.
There was a problem hiding this comment.
sounds good, updated to the same message, thank you!
|
@wzssyqa please take a look, I should have resolved your comment, thank you! |
|
Thanks for your work. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/13621 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/10659 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/10254 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/10530 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/11872 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only an Expr is supported by JAL.
Let's check it before getExpr.
#80535