Add a pass to collect dropped var stats for MIR #120780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch uses the DroppedVariableStats class to add dropped variable statistics for MIR passes. Reland 1c082c9
chapuni
reviewed
Dec 20, 2024
| #define LLVM_CODEGEN_DROPPEDVARIABLESTATSMIR_H | ||
|
|
||
| #include "llvm/CodeGen/MachineFunction.h" | ||
| #include "llvm/Passes/DroppedVariableStats.h" |
There was a problem hiding this comment.
It's odd to depend on LLVMPasses here.
chapuni
added a commit
that referenced
this pull request
Dec 21, 2024
This reverts commit 3bf91ad. (llvmorg-20-init-16123-g3bf91ad2a9c7) `llvm/CodeGen` should not depend on `llvm/Passes`.
|
I have reverted this. I could fix them though. |
|
I have already commented on this three times... #115566 (comment) ...and my feedback still hasn't been addressed. If you reapply this again without actually addressing the problems with this patch, I will request your commit access to be withdrawn. |
|
@nikic I am very sorry about not addressing the patch issues, I will make sure to not include so much code into MachineFunctionPass.h. I had applied some aggressive filtering in my email and didn't see those comments, but I understand it is not an excuse. Do you have some recommendations on how to redesign this better to make it so that the build times are smaller? |
|
@chapuni The reason I designed it this way, is because if I move all the With this error: This is because libclang/codegen doesn't link against libllvm/codegen however, it does link against libllvm/passes. If I cannot have libllvm/codegen not link against passes, then I am unsure of where I can put the code so that I can calculate dropped statistics for both IR and MIR. Do you have an idea of what could be done? |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1904 Here is the relevant piece of the build log for the reference |
rastogishubham
added a commit
to rastogishubham/llvm-project
that referenced
this pull request
Feb 5, 2025
|
|
rastogishubham
added a commit
that referenced
this pull request
Feb 12, 2025
This patch attempts to reland #120780 while addressing the issues that caused the patch to be reverted. Namely: 1. The patch had included code from the llvm/Passes directory in the llvm/CodeGen directory. 2. The patch increased the backend compile time by 2% due to adding a very expensive include in MachineFunctionPass.h The patch has been re-structured so that there is no dependency between the llvm/Passes and llvm/CodeGen directory, by moving the base class, `class DroppedVariableStats` to the llvm/IR directory. The expensive include in MachineFunctionPass.h has been changed to contain forward declarations instead of other header includes which was pulling a ton of code into MachineFunctionPass.h and should resolve any issues when it comes to compile time increase.
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 12, 2025
…686) This patch attempts to reland llvm/llvm-project#120780 while addressing the issues that caused the patch to be reverted. Namely: 1. The patch had included code from the llvm/Passes directory in the llvm/CodeGen directory. 2. The patch increased the backend compile time by 2% due to adding a very expensive include in MachineFunctionPass.h The patch has been re-structured so that there is no dependency between the llvm/Passes and llvm/CodeGen directory, by moving the base class, `class DroppedVariableStats` to the llvm/IR directory. The expensive include in MachineFunctionPass.h has been changed to contain forward declarations instead of other header includes which was pulling a ton of code into MachineFunctionPass.h and should resolve any issues when it comes to compile time increase.
rastogishubham
added a commit
to rastogishubham/llvm-project
that referenced
this pull request
Feb 13, 2025
This patch attempts to reland llvm#120780 while addressing the issues that caused the patch to be reverted. Namely: 1. The patch had included code from the llvm/Passes directory in the llvm/CodeGen directory. 2. The patch increased the backend compile time by 2% due to adding a very expensive include in MachineFunctionPass.h The patch has been re-structured so that there is no dependency between the llvm/Passes and llvm/CodeGen directory, by moving the base class, `class DroppedVariableStats` to the llvm/IR directory. The expensive include in MachineFunctionPass.h has been changed to contain forward declarations instead of other header includes which was pulling a ton of code into MachineFunctionPass.h and should resolve any issues when it comes to compile time increase. (cherry picked from commit 92f916f)
flovent
pushed a commit
to flovent/llvm-project
that referenced
this pull request
Feb 13, 2025
This patch attempts to reland llvm#120780 while addressing the issues that caused the patch to be reverted. Namely: 1. The patch had included code from the llvm/Passes directory in the llvm/CodeGen directory. 2. The patch increased the backend compile time by 2% due to adding a very expensive include in MachineFunctionPass.h The patch has been re-structured so that there is no dependency between the llvm/Passes and llvm/CodeGen directory, by moving the base class, `class DroppedVariableStats` to the llvm/IR directory. The expensive include in MachineFunctionPass.h has been changed to contain forward declarations instead of other header includes which was pulling a ton of code into MachineFunctionPass.h and should resolve any issues when it comes to compile time increase.
joaosaffran
pushed a commit
to joaosaffran/llvm-project
that referenced
this pull request
Feb 14, 2025
This patch attempts to reland llvm#120780 while addressing the issues that caused the patch to be reverted. Namely: 1. The patch had included code from the llvm/Passes directory in the llvm/CodeGen directory. 2. The patch increased the backend compile time by 2% due to adding a very expensive include in MachineFunctionPass.h The patch has been re-structured so that there is no dependency between the llvm/Passes and llvm/CodeGen directory, by moving the base class, `class DroppedVariableStats` to the llvm/IR directory. The expensive include in MachineFunctionPass.h has been changed to contain forward declarations instead of other header includes which was pulling a ton of code into MachineFunctionPass.h and should resolve any issues when it comes to compile time increase.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Feb 24, 2025
This patch attempts to reland llvm#120780 while addressing the issues that caused the patch to be reverted. Namely: 1. The patch had included code from the llvm/Passes directory in the llvm/CodeGen directory. 2. The patch increased the backend compile time by 2% due to adding a very expensive include in MachineFunctionPass.h The patch has been re-structured so that there is no dependency between the llvm/Passes and llvm/CodeGen directory, by moving the base class, `class DroppedVariableStats` to the llvm/IR directory. The expensive include in MachineFunctionPass.h has been changed to contain forward declarations instead of other header includes which was pulling a ton of code into MachineFunctionPass.h and should resolve any issues when it comes to compile time increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the DroppedVariableStats class to add dropped variable statistics for MIR passes.
Reland 1c082c9