[AArch64][SME] Fix broken compiler check for SME2 support in compiler-rt #121625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-rt. This compile time test uses inline asm with .arch directives to set the target feature. It is however broken and always fails, since each asm() construct in LLVM sets up a new AsmParser, and therefore the .arch directive has no effect on later asm() contents. To fix this we need to use a single inline asm() call with the entire code chunk to emit contained inside.
sdesmalen-arm
approved these changes
Jan 6, 2025
paulhuggett
pushed a commit
to paulhuggett/llvm-project
that referenced
this pull request
Jan 7, 2025
…-rt (llvm#121625) This compile time test uses inline asm with `.arch` directives to set the target feature. It is however broken and always fails, since each `asm()` construct in LLVM sets up a new AsmParser, and therefore the `.arch` directive has no effect on later `asm()` contents. To fix this we need to use a single inline `asm()` call with the entire code chunk to emit contained inside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compile time test uses inline asm with
.archdirectives to set the target feature. It is however broken and always fails, since eachasm()construct in LLVM sets up a new AsmParser, and therefore the.archdirective has no effect on laterasm()contents. To fix this we need to use a single inlineasm()call with the entire code chunk to emit contained inside.