-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[bazel] Add rules for clang-fuzzer protobuf-related libraries #123126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could we split out clang-proto-fuzzer stuff into the directory (for me to exclude them easily)? For now, I have:
|
I'm not opposed to this, but if these targets are causing you problems I'd like to know more details. I tested this on a machine without Does it need to be a separate directory or would something like a
Do you mean only the proto-related stuff, or everything clang-fuzzer? If it's the former, we don't need to exclude |
Thanks for your considerations. I am using I don't use the in-tree |
I think something like #123833 should do the trick. |
- The actual reason I started this: minor lowering updates in the golden LLVM IR - Process.inc changed enough to need a patch context update. - llvm/llvm-project#123126 added `proto_library` uses without a `load`, which is broken in bazel 8 - Just commenting these out because we don't use them. I'll follow up separately about a possible fix, but continuing to use `WORKSPACE` is a bigger issue LLVM probably should address. - Note this update is also triggering removal of `migrate_cpp`, in #4887
- The actual reason I started this: minor lowering updates in the golden LLVM IR - Process.inc changed enough to need a patch context update. - llvm/llvm-project#123126 added `proto_library` uses without a `load`, which is broken in bazel 8 - Just commenting these out because we don't use them. I'll follow up separately about a possible fix, but continuing to use `WORKSPACE` is a bigger issue LLVM probably should address. - Note this update is also triggering removal of `migrate_cpp`, in #4887
- The actual reason I started this: minor lowering updates in the golden LLVM IR - Process.inc changed enough to need a patch context update. - llvm/llvm-project#123126 added `proto_library` uses without a `load`, which is broken in bazel 8 - Just commenting these out because we don't use them. I'll follow up separately about a possible fix, but continuing to use `WORKSPACE` is a bigger issue LLVM probably should address. - Note this update is also triggering removal of `migrate_cpp`, in #4887
- The actual reason I started this: minor lowering updates in the golden LLVM IR - Process.inc changed enough to need a patch context update. - llvm/llvm-project#123126 added `proto_library` uses without a `load`, which is broken in bazel 8 - Just commenting these out because we don't use them. I'll follow up separately about a possible fix, but continuing to use `WORKSPACE` is a bigger issue LLVM probably should address. - Note this update is also triggering removal of `migrate_cpp`, in #4887
Also bumped up bazel_skylib to the latest version because the proto rules were complaining about a missing feature.