[MLIR][test] Fixup for checking for ml_dtypes

[kwk]

In order to optionally run some checks that depend on the ml_dtypes python module we have to remove the CHECK lines for those tests or they will be required and missed in the test output.

I've changed to use asserts as recommended in 1.

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Konrad Kleine (kwk)

Changes

In order to optionally run some checks that depend on the ml_dtypes python module we have to remove the CHECK lines for those tests or they will be required and missed in the test output.

I've changed to use asserts as recommended in 1.

---

Full diff: https://github.com/llvm/llvm-project/pull/123240.diff

1 Files Affected:

• (modified) mlir/test/python/execution_engine.py (+6-8)

diff --git a/mlir/test/python/execution_engine.py b/mlir/test/python/execution_engine.py
index e3f41815800d58..cab6b69a01f4cc 100644
--- a/mlir/test/python/execution_engine.py
+++ b/mlir/test/python/execution_engine.py
@@ -536,7 +536,6 @@ def testComplexUnrankedMemrefAdd():
 
 
 # Test bf16 memrefs
-# CHECK-LABEL: TEST: testBF16Memref
 def testBF16Memref():
     with Context():
         module = Module.parse(
@@ -566,9 +565,9 @@ def testBF16Memref():
         execution_engine.invoke("main", arg1_memref_ptr, arg2_memref_ptr)
 
         # test to-numpy utility
-        # CHECK: [0.5]
-        npout = ranked_memref_to_numpy(arg2_memref_ptr[0])
-        log(npout)
+        x = ranked_memref_to_numpy(arg2_memref_ptr[0])
+        assert len(x) == 1
+        assert x[0] == 0.5
 
 
 if HAS_ML_DTYPES:
@@ -576,7 +575,6 @@ def testBF16Memref():
 
 
 # Test f8E5M2 memrefs
-# CHECK-LABEL: TEST: testF8E5M2Memref
 def testF8E5M2Memref():
     with Context():
         module = Module.parse(
@@ -606,9 +604,9 @@ def testF8E5M2Memref():
         execution_engine.invoke("main", arg1_memref_ptr, arg2_memref_ptr)
 
         # test to-numpy utility
-        # CHECK: [0.5]
-        npout = ranked_memref_to_numpy(arg2_memref_ptr[0])
-        log(npout)
+        x = ranked_memref_to_numpy(arg2_memref_ptr[0])
+        assert len(x) == 1
+        assert x[0] == 0.5
 
 
 if HAS_ML_DTYPES:

[makslevental]

sorry why not the

if HAS_ML_DTYPES:
    run(testF8E5M2Memref)
else:
    print("TEST: testF8E5M2Memref")

I suggested?

[kwk]

Originally I had this even before you suggested it but it didn't work. Today when I put the prints (I used log()) back in in order to show the error it did work. What can I say other than sorry and thank you. I'll update the PR shortly.

[kwk]

@makslevental I've update the PR and would be super happy if you could take a look again. Thank you for accepting my PRs and helping me fix them btw. This is very welcoming.

[makslevental]

ofc ofc no problem

[makslevental]

LGTM! Hopefully it works on your end now :)