Add "avoidmuls" to STAR-MC1 also #123706
Merged
Add "avoidmuls" to STAR-MC1 also #123706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-arm Author: Albert Huang (AlbertHuang-CPU) ChangesPR #112540 as the reference. Full diff: https://github.com/llvm/llvm-project/pull/123706.diff 2 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMProcessors.td b/llvm/lib/Target/ARM/ARMProcessors.td
index 213b104bcfdb2f..7453727a7cff0c 100644
--- a/llvm/lib/Target/ARM/ARMProcessors.td
+++ b/llvm/lib/Target/ARM/ARMProcessors.td
@@ -377,6 +377,7 @@ def : ProcessorModel<"star-mc1", CortexM4Model, [ARMv8mMainline,
FeatureHasSlowFPVFMx,
FeatureUseMISched,
FeatureHasNoBranchPredictor,
+ FeatureAvoidMULS,
FeatureFixCMSE_CVE_2021_35465]>;
def : ProcessorModel<"cortex-m35p", CortexM4Model, [ARMv8mMainline,
diff --git a/llvm/test/CodeGen/Thumb2/avoidmuls.mir b/llvm/test/CodeGen/Thumb2/avoidmuls.mir
index 865152068fdf7f..7bfa4b90600637 100644
--- a/llvm/test/CodeGen/Thumb2/avoidmuls.mir
+++ b/llvm/test/CodeGen/Thumb2/avoidmuls.mir
@@ -1,4 +1,5 @@
# RUN: llc -mtriple=thumbv7m-none-eabi -mcpu=cortex-m33 -run-pass=thumb2-reduce-size %s -o - | FileCheck %s --check-prefix=MUL
+# RUN: llc -mtriple=thumbv7m-none-eabi -mcpu=star-mc1 -run-pass=thumb2-reduce-size %s -o - | FileCheck %s --check-prefix=MUL
# RUN: llc -mtriple=thumbv7m-none-eabi --run-pass=thumb2-reduce-size %s -o - | FileCheck %s --check-prefix=MULS
---
@@ -17,4 +18,4 @@ body: |
# MULS-LABEL: test
# MULS: tMUL
-# MULS-NOT: t2MUL
\ No newline at end of file
+# MULS-NOT: t2MUL
|
|
Sorry - we never remember who does and doesn't have commit access. Are you happy for us to submit the current version? |
|
Sure, please. And sorry I should have asked your help for the commit.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: David Green ***@***.***>
Sent: Friday, January 31, 2025 9:57:13 PM
To: llvm/llvm-project ***@***.***>
Cc: Albert Huang ***@***.***>; Author ***@***.***>
Subject: Re: [llvm/llvm-project] Add "avoidmuls" to STAR-MC1 also (PR #123706)
[WARNING:This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. ]
[提醒：这是一封源自于我司之外的邮件。在您无法正确识别发件人完整的邮件地址或无法确认邮件内容安全的情况下，请不要点击任何邮件内链接或打开附件文件！]
Sorry - we never remember who does and doesn't have commit access. Are you happy for us to submit the current version?
―
Reply to this email directly, view it on GitHub<#123706 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN45N2RI3MUWK34KES46EHD2NN6LTAVCNFSM6AAAAABVR4LZJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRXGQYTMNJYHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
IMPORTANT NOTICE: The contents of this email and any attachments may be privileged and confidential. If you are not the intended recipient, please delete the email immediately. It is strictly prohibited to disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. (c)Arm Technology (China) Co., Ltd copyright and reserve all rights. 重要提示：本邮件（包括任何附件）可能含有专供明确的个人或目的使用的机密信息，并受法律保护。如果您并非该收件人，请立即删除此邮件。严禁通过任何渠道，以任何目的，向任何人披露、储存或复制邮件信息或者据此采取任何行动。感谢您的配合。 (c)安谋科技（中国）有限公司 版权所有并保留一切权利。
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/10985 Here is the relevant piece of the build log for the reference |
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
PR llvm#112540 as the reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #112540 as the reference.