Skip to content

[libc][workflow] improve ci coverage with windows-2025 and arm ubuntu #123745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/libc-fullbuild-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,16 @@ on:

jobs:
build:
runs-on: ubuntu-24.04
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
include:
- c_compiler: clang
- os: ubuntu-24.04
c_compiler: clang
cpp_compiler: clang++
- os: ubuntu-24.04-arm
c_compiler: clang
cpp_compiler: clang++
# TODO: add back gcc build when it is fixed
# - c_compiler: gcc
Expand All @@ -32,6 +36,7 @@ jobs:
# frequent small object writes.
- name: Setup ccache
uses: hendrikmuhs/[email protected]
if: runner.arch == 'X64'
with:
max-size: 1G
key: libc_fullbuild_${{ matrix.c_compiler }}
Expand All @@ -42,10 +47,16 @@ jobs:
# - Debian has a multilib setup, so we need to symlink the asm directory.
# For more information, see https://wiki.debian.org/Multiarch/LibraryPathOverview
- name: Prepare dependencies (Ubuntu)
shell: bash
run: |
sudo apt-get update
sudo apt-get install -y libmpfr-dev libgmp-dev libmpc-dev ninja-build linux-libc-dev
sudo ln -sf /usr/include/$(uname -p)-linux-gnu/asm /usr/include/asm
if [[ $(uname -m) == 'aarch64' ]]; then
wget https://github.com/mozilla/sccache/releases/download/v0.9.1/sccache-v0.9.1-aarch64-unknown-linux-musl.tar.gz
tar xvaf sccache-v0.9.1-aarch64-unknown-linux-musl.tar.gz
sudo cp sccache-v0.9.1-aarch64-unknown-linux-musl/sccache /usr/bin
fi

- name: Set reusable strings
id: strings
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/libc-overlay-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,18 @@ jobs:
compiler:
c_compiler: clang
cpp_compiler: clang++
- os: ubuntu-24.04-arm
compiler:
c_compiler: clang
cpp_compiler: clang++
- os: windows-2022
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: windows-2025
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: macos-14
compiler:
c_compiler: clang
Expand All @@ -43,6 +51,7 @@ jobs:
# frequent small object writes.
- name: Setup ccache
uses: hendrikmuhs/ccache-action@v1
if: runner.arch == 'X64'
with:
max-size: 1G
key: libc_overlay_build_${{ matrix.os }}_${{ matrix.compiler.c_compiler }}
Expand All @@ -54,6 +63,11 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install -y libmpfr-dev libgmp-dev libmpc-dev ninja-build
if [[ $(uname -m) == 'aarch64' ]]; then
wget https://github.com/mozilla/sccache/releases/download/v0.9.1/sccache-v0.9.1-aarch64-unknown-linux-musl.tar.gz
tar xvaf sccache-v0.9.1-aarch64-unknown-linux-musl.tar.gz
sudo cp sccache-v0.9.1-aarch64-unknown-linux-musl/sccache /usr/bin
fi

# Chocolatey is shipped with Windows runners. Windows Server 2025 recommends WinGet.
# Consider migrating to WinGet when Windows Server 2025 is available.
Expand Down
Loading