[clang][docs] Fix typos concerning wasm __funcref #124365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-webassembly @llvm/pr-subscribers-clang Author: Timothy Herchen (anematode) ChangesThe docs conflate Full diff: https://github.com/llvm/llvm-project/pull/124365.diff 1 Files Affected:
diff --git a/clang/docs/LanguageExtensions.rst b/clang/docs/LanguageExtensions.rst
index c42b88015e2695..ddb11cc6efb232 100644
--- a/clang/docs/LanguageExtensions.rst
+++ b/clang/docs/LanguageExtensions.rst
@@ -2632,7 +2632,7 @@ with the current table size.
.. code-block:: c++
typedef void (*__funcref funcref_t)();
- static __funcref table[0];
+ static funcref_t table[0];
size_t getSize() {
return __builtin_wasm_table_size(table);
@@ -2654,10 +2654,10 @@ or -1. It will return -1 if not enough space could be allocated.
.. code-block:: c++
typedef void (*__funcref funcref_t)();
- static __funcref table[0];
+ static funcref_t table[0];
// grow returns the new table size or -1 on error.
- int grow(__funcref fn, int delta) {
+ int grow(funcref_t fn, int delta) {
int prevSize = __builtin_wasm_table_grow(table, fn, delta);
if (prevSize == -1)
return -1;
|
dschuff
reviewed
Jan 27, 2025
| @@ -1211,6 +1211,15 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo &CLI, | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // If outgoing arguments are passed via the stack, we cannot tail call | |||
| for (const ISD::OutputArg &Out : CLI.Outs) { | |||
There was a problem hiding this comment.
This is a completely unrelated change. Can it be split out into a separate PR (preferably with a test?)
There was a problem hiding this comment.
Aha, i just got one item deeper into my queue and discovered #124443, thanks :)
Please just delete this change from the PR.
|
Pardon? (Last time I made a PR my commit was merged directly, but I don't mind if you commit a trivial one like this) |
wldfngrs
pushed a commit
to wldfngrs/llvm-project
that referenced
this pull request
Feb 19, 2025
The docs conflate `__funcref` with an actual type in a couple places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs conflate
__funcrefwith an actual type in a couple places.