Skip to content

PeepholeOpt: Avoid double map lookup #124531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2025
Merged

PeepholeOpt: Avoid double map lookup #124531

merged 3 commits into from
Jan 30, 2025

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Jan 27, 2025

No description provided.

This was referenced Jan 27, 2025
Merged
Merged
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 27, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arsenm arsenm mentioned this pull request Jan 27, 2025
Merged
@arsenm arsenm marked this pull request as ready for review January 27, 2025 11:37
@arsenm arsenm requested a review from kazutakahirata January 27, 2025 11:38
jayfoad
jayfoad reviewed Jan 27, 2025
View reviewed changes
kazutakahirata
kazutakahirata approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See a comment above about const &.

@arsenm arsenm force-pushed the users/arsenm/peephole-opt-remove-reg-sequence-subreg-def-check branch from 436cde0 to 8d6f4a9 Compare January 30, 2025 03:47
@arsenm arsenm force-pushed the users/arsenm/peephole-opt-avoid-double-map-lookup branch from 48fcc3c to 159d577 Compare January 30, 2025 03:47
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 30, 2025 •
edited
Loading

Merge activity

  • Jan 30, 8:37 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 30, 8:57 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 30, 9:00 AM EST: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/peephole-opt-remove-reg-sequence-subreg-def-check branch from 8d6f4a9 to c40506b Compare January 30, 2025 13:52
Base automatically changed from users/arsenm/peephole-opt-remove-reg-sequence-subreg-def-check to main January 30, 2025 13:55
@arsenm arsenm force-pushed the users/arsenm/peephole-opt-avoid-double-map-lookup branch from 159d577 to 2def9c1 Compare January 30, 2025 13:56
@arsenm arsenm merged commit fe1f6b4 into main Jan 30, 2025
5 of 6 checks passed
@arsenm arsenm deleted the users/arsenm/peephole-opt-avoid-double-map-lookup branch January 30, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayfoad jayfoad jayfoad approved these changes

@kazutakahirata kazutakahirata kazutakahirata approved these changes

@kparzysz kparzysz Awaiting requested review from kparzysz

@Pierre-vh Pierre-vh Awaiting requested review from Pierre-vh

@qcolombet qcolombet Awaiting requested review from qcolombet

@RKSimon RKSimon Awaiting requested review from RKSimon

@shiltian shiltian Awaiting requested review from shiltian

@topperc topperc Awaiting requested review from topperc

Assignees
No one assigned
Labels
llvm:codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arsenm @jayfoad @kazutakahirata