Skip to content

[libclc] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES #124709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[libclc] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES #124709

wants to merge 1 commit into from

Conversation

petrhosek
Copy link
Member

We plan to make this a hard error in the LLVM 21 release.

Link #124013

@petrhosek
[libclc] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES
d685373 
We plan to make this a hard error in the LLVM 21 release.

Link llvm#124013
@petrhosek petrhosek added cmake Build system in general and CMake in particular libclc libclc OpenCL library labels Jan 28, 2025
frasercrmck
frasercrmck reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message suggests using -DLLVM_ENABLE_RUNTIMES=libclc but libclc isn't in LLVM_SUPPORTED_RUNTIMES. Am I reading this correctly?

@frasercrmck frasercrmck mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frasercrmck frasercrmck frasercrmck left review comments

@tstellar tstellar Awaiting requested review from tstellar

Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular libclc libclc OpenCL library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrhosek @frasercrmck