[flang] Repair recent Power build bot breakage #124950

klausler · 2025-01-29T17:08:22Z

Add AIX_WARNING expected warnings to a test that is now producing new warnings.

Should fix https://lab.llvm.org/buildbot/#/builders/201/builds/2291.

llvmbot · 2025-01-29T17:08:57Z

@llvm/pr-subscribers-flang-semantics

Author: Peter Klausler (klausler)

Changes

Add AIX_WARNING expected warnings to a test that is now producing new warnings.

Should fix https://lab.llvm.org/buildbot/#/builders/201/builds/2291.

Full diff: https://github.com/llvm/llvm-project/pull/124950.diff

1 Files Affected:

(modified) flang/test/Semantics/kinds04_q10.f90 (+3)

diff --git a/flang/test/Semantics/kinds04_q10.f90 b/flang/test/Semantics/kinds04_q10.f90
index aa5c4abe2f1dfc..091bbbc19444dc 100644
--- a/flang/test/Semantics/kinds04_q10.f90
+++ b/flang/test/Semantics/kinds04_q10.f90
@@ -11,11 +11,13 @@ subroutine s(var)
   real :: realvar3 = 4.0Q6
   !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
   real :: realvar4 = 4.0D6_8
+  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
   !WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'
   real :: realvar5 = 4.0Q6_10
   !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
   real :: realvar6 = 4.0Q6_16
   real :: realvar7 = 4.0E6_8
+  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
   real :: realvar8 = 4.0E6_10
   real :: realvar9 = 4.0E6_16
   !ERROR: Unsupported REAL(KIND=32)
@@ -29,6 +31,7 @@ subroutine s(var)
   !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
   double precision :: doublevar5 = 4.0Q6_16
   double precision :: doublevar6 = 4.0E6_8
+  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
   double precision :: doublevar7 = 4.0E6_10
   double precision :: doublevar8 = 4.0E6_16
   !ERROR: Unsupported REAL(KIND=32)

kkwli · 2025-01-29T18:02:56Z

I guess something is missing. How is AIX_WARNING used?

kkwli · 2025-01-29T18:05:46Z

I see this when I fetch your branch.

! RUN: not %flang_fc1 %s 2>%t.stderr
! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR"%}

kkwli · 2025-01-29T18:53:21Z

I think kinds04_q10.f90 also need to be updated.

$ $HOME/wrk/f/build-flang-local/bin/llvm-lit -v --param flang_site_config=$HOME/wrk/f/build-flang-local/tools/flang/test/lit.site.cfg.py --param flang_config=$HOME/wrk/f/build-flang-local/tools/flang/test/lit.cfg.py $HOME/llvm-project/flang/test/Semantics/kinds04_q10.f90
-- Testing: 1 tests, 1 workers --
FAIL: Flang :: Semantics/kinds04_q10.f90 (1 of 1)
******************** TEST 'Flang :: Semantics/kinds04_q10.f90' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
--- 
+++ 
@@ -3 +2,0 @@

actual at 16: underflow on REAL(10) to REAL(4) conversion@@ -5 +3,0 @@

actual at 21: underflow on REAL(10) to REAL(4) conversion@@ -9 +6,0 @@

actual at 35: underflow on REAL(10) to REAL(8) conversion

FAIL

--
Command Output (stderr):
--
RUN: at line 1: "/usr/bin/python3" /home/kli/llvm-project/flang/test/Semantics/test_errors.py /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90 /home/kli/wrk/f/build-flang-local/bin/flang -fc1
+ /usr/bin/python3 /home/kli/llvm-project/flang/test/Semantics/test_errors.py /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90 /home/kli/wrk/f/build-flang-local/bin/flang -fc1

--

********************
********************
Failed Tests (1):
  Flang :: Semantics/kinds04_q10.f90


Testing Time: 0.55s

Total Discovered Tests: 1
  Failed: 1 (100.00%)

klausler · 2025-01-29T20:30:04Z

Thanks; done.

kkwli · 2025-01-29T21:05:43Z

flang/test/Semantics/kinds04_q10.f90

@@ -29,6 +32,7 @@ subroutine s(var)
  !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
  double precision :: doublevar5 = 4.0Q6_16


kinds04_q10.f90:33:36: portability: Explicit kind parameter together with non-'E' exponent letter is not standard double precision :: doublevar5 = 4.0Q6_16 ^^^^^

kkwli · 2025-01-29T21:07:30Z

flang/test/Semantics/kinds04_q10.f90

@@ -29,6 +32,7 @@ subroutine s(var)
  !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
  double precision :: doublevar5 = 4.0Q6_16
  double precision :: doublevar6 = 4.0E6_8
+  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
  double precision :: doublevar7 = 4.0E6_10
  double precision :: doublevar8 = 4.0E6_16
  !ERROR: Unsupported REAL(KIND=32)


on line 39:

kinds04_q10.f90:39:36: error: Unsupported REAL(KIND=32) double precision :: doublevar9 = 4.0E6_32 ^^^^^

kkwli · 2025-01-29T21:08:55Z

on powerpc64-*-aix:

$ $HOME/wrk/f/build-flang-local/bin/llvm-lit -v --param flang_site_config=$HOME/wrk/f/build-flang-local/tools/flang/test/lit.site.cfg.py --param flang_config=$HOME/wrk/f/build-flang-local/tools/flang/test/lit.cfg.py $HOME/llvm-project/flang/test/Semantics/kinds04_q10.f90
-- Testing: 1 tests, 1 workers --
FAIL: Flang :: Semantics/kinds04_q10.f90 (1 of 1)
******************** TEST 'Flang :: Semantics/kinds04_q10.f90' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: not /home/kli/wrk/f/build-flang-local/bin/flang -fc1 /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90 2>/home/kli/wrk/f/build-flang-local/tools/flang/test/Semantics/Output/kinds04_q10.f90.tmp.stderr
+ not /home/kli/wrk/f/build-flang-local/bin/flang -fc1 /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90
RUN: at line 2: /home/kli/wrk/f/build-flang-local/bin/FileCheck /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90 --input-file=/home/kli/wrk/f/build-flang-local/tools/flang/test/Semantics/Output/kinds04_q10.f90.tmp.stderr --check-prefixes="PORTABILITY","WARNING","ERROR","AIX_WARNING"
+ /home/kli/wrk/f/build-flang-local/bin/FileCheck /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90 --input-file=/home/kli/wrk/f/build-flang-local/tools/flang/test/Semantics/Output/kinds04_q10.f90.tmp.stderr --check-prefixes=PORTABILITY,WARNING,ERROR,AIX_WARNING
/home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90:16:12: error: WARNING: expected string not found in input
 !WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'
           ^
/home/kli/wrk/f/build-flang-local/tools/flang/test/Semantics/Output/kinds04_q10.f90.tmp.stderr:26:120: note: scanning from here
/home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90:36:36: warning: underflow on REAL(10) to REAL(8) conversion
                                                                                                                       ^

Input file: /home/kli/wrk/f/build-flang-local/tools/flang/test/Semantics/Output/kinds04_q10.f90.tmp.stderr
Check file: /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90

-dump-input=help explains the following input dump.

Input was:
<<<<<<
          .
          .
          .
         21:  double precision :: doublevar4 = 4.0D6_8 
         22:  ^^^^^ 
         23: /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90:33:36: portability: Explicit kind parameter together with non-'E' exponent letter is not standard 
         24:  double precision :: doublevar5 = 4.0Q6_16 
         25:  ^^^^^ 
         26: /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90:36:36: warning: underflow on REAL(10) to REAL(8) conversion 
check:16                                                                                                                            X error: no match found
         27:  double precision :: doublevar7 = 4.0E6_10 
check:16     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         28:  ^^^^^^^^ 
check:16     ~~~~~~~~~~
         29: /home/kli/llvm-project/flang/test/Semantics/kinds04_q10.f90:39:36: error: Unsupported REAL(KIND=32) 
check:16     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         30:  double precision :: doublevar9 = 4.0E6_32 
check:16     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         31:  ^^^^^ 
check:16     ~~~~~~~
>>>>>>

--

********************
********************
Failed Tests (1):
  Flang :: Semantics/kinds04_q10.f90


Testing Time: 0.41s

Total Discovered Tests: 1
  Failed: 1 (100.00%)

kkwli · 2025-01-29T22:46:58Z

This works for ppc64le-*-linux and powerpc*-*-aix.

diff --git a/flang/test/Semantics/kinds04_q10.f90 b/flang/test/Semantics/kinds04_q10.f90
index 45b72fb19184..1063697e1380 100644
--- a/flang/test/Semantics/kinds04_q10.f90
+++ b/flang/test/Semantics/kinds04_q10.f90
@@ -1,5 +1,5 @@
 ! RUN: not %flang_fc1 %s 2>%t.stderr
-! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR","NON_AIX_WARNING"%}
+! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR"%}
 ! C716 If both kind-param and exponent-letter appear, exponent-letter
 ! shall be E. (As an extension we also allow an exponent-letter which matches
 ! the kind-param)
@@ -12,13 +12,13 @@ subroutine s(var)
   real :: realvar3 = 4.0Q6
   !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
   real :: realvar4 = 4.0D6_8
-  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
-  !NON_AIX_WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'
+  !WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'
+  !AIX_WARNING: underflow on REAL(10) to REAL(4) conversion
   real :: realvar5 = 4.0Q6_10
   !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
   real :: realvar6 = 4.0Q6_16
   real :: realvar7 = 4.0E6_8
-  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
+  !AIX_WARNING: underflow on REAL(10) to REAL(4) conversion
   real :: realvar8 = 4.0E6_10
   real :: realvar9 = 4.0E6_16
   !ERROR: Unsupported REAL(KIND=32)

klausler · 2025-01-30T16:19:30Z

Please approve, @kkwli , if you're happy with this change, or let me know what else needs to be done; thanks.

klausler · 2025-01-30T16:22:38Z

Oh, sorry, I didn't notice the CI failure. Hang on, please.

kkwli · 2025-01-30T16:25:08Z

flang/test/Semantics/kinds04_q10.f90

@@ -1,4 +1,5 @@
-! RUN: %python %S/test_errors.py %s %flang_fc1
+! RUN: not %flang_fc1 %s 2>%t.stderr
+! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR","NON_AIX_WARNING"%}


Suggested change

! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR","NON_AIX_WARNING"%}

! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR"%}

kkwli · 2025-01-30T16:26:14Z

flang/test/Semantics/kinds04_q10.f90

+  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
+  !NON_AIX_WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'


Suggested change

!AIX_WARNING: underflow on REAL(10) to REAL(8) conversion

!NON_AIX_WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'

!WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'

!AIX_WARNING: underflow on REAL(10) to REAL(4) conversion

kkwli · 2025-01-30T16:26:36Z

flang/test/Semantics/kinds04_q10.f90

  real :: realvar5 = 4.0Q6_10
  !PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
  real :: realvar6 = 4.0Q6_16
  real :: realvar7 = 4.0E6_8
+  !AIX_WARNING: underflow on REAL(10) to REAL(8) conversion


Suggested change

!AIX_WARNING: underflow on REAL(10) to REAL(8) conversion

!AIX_WARNING: underflow on REAL(10) to REAL(4) conversion

kkwli · 2025-01-30T16:27:49Z

The suggested changes can make things work on ppc64le-*-linux and powerpc*-*-aix.

Add AIX_WARNING expected warnings to a test that is now producing new warnings. Should fix https://lab.llvm.org/buildbot/#/builders/201/builds/2291.

klausler · 2025-01-30T16:32:33Z

Should be good to go now.

kkwli

LGTM. Thanks for the fix.

klausler requested a review from kkwli January 29, 2025 17:08

llvmbot added flang Flang issues not falling into any other category flang:semantics labels Jan 29, 2025

klausler force-pushed the fix-power branch from abe367e to d669de0 Compare January 29, 2025 20:29

kkwli reviewed Jan 29, 2025

View reviewed changes

klausler force-pushed the fix-power branch from d669de0 to 7733f82 Compare January 29, 2025 21:44

kkwli mentioned this pull request Jan 30, 2025

[Flang] [AIX] Mark real10 testcase as unsupported on AIX NFC #125076

Closed

kkwli reviewed Jan 30, 2025

View reviewed changes

[flang] Repair recent Power build bot breakage

612aa61

Add AIX_WARNING expected warnings to a test that is now producing new warnings. Should fix https://lab.llvm.org/buildbot/#/builders/201/builds/2291.

klausler force-pushed the fix-power branch from 7733f82 to 612aa61 Compare January 30, 2025 16:32

kkwli approved these changes Jan 30, 2025

View reviewed changes

klausler merged commit b4d52a9 into llvm:main Jan 30, 2025
7 checks passed

klausler deleted the fix-power branch January 30, 2025 19:41

		@@ -29,6 +32,7 @@ subroutine s(var)
		!PORTABILITY: Explicit kind parameter together with non-'E' exponent letter is not standard
		double precision :: doublevar5 = 4.0Q6_16

	! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR","NON_AIX_WARNING"%}
	! RUN: FileCheck %s --input-file=%t.stderr --check-prefixes=%if system-aix %{"PORTABILITY","WARNING","ERROR","AIX_WARNING"%} %else %{"PORTABILITY","WARNING","ERROR"%}

		!AIX_WARNING: underflow on REAL(10) to REAL(8) conversion
		!NON_AIX_WARNING: Explicit kind parameter on real constant disagrees with exponent letter 'q'

[flang] Repair recent Power build bot breakage #124950

[flang] Repair recent Power build bot breakage #124950

Uh oh!

Conversation

klausler commented Jan 29, 2025

Uh oh!

llvmbot commented Jan 29, 2025

Uh oh!

kkwli commented Jan 29, 2025

Uh oh!

kkwli commented Jan 29, 2025

Uh oh!

kkwli commented Jan 29, 2025

Uh oh!

klausler commented Jan 29, 2025

Uh oh!

kkwli Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

kkwli Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

kkwli commented Jan 29, 2025

Uh oh!

kkwli commented Jan 29, 2025

Uh oh!

klausler commented Jan 30, 2025

Uh oh!

klausler commented Jan 30, 2025

Uh oh!

kkwli Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

kkwli Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

kkwli Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

kkwli commented Jan 30, 2025

Uh oh!

klausler commented Jan 30, 2025

Uh oh!

kkwli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!