[LLDB][Save Core Options] Custom ranges should follow the same safety checks as everyone else #125323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se, to avoid empty ranges, or ranges with no permissions
|
@llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) ChangesI encountered a Full diff: https://github.com/llvm/llvm-project/pull/125323.diff 1 Files Affected:
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index 89731f798deda8..428f8519b72fd5 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -6677,11 +6677,8 @@ static void GetUserSpecifiedCoreFileSaveRanges(Process &process,
for (const auto &range : regions) {
auto entry = option_ranges.FindEntryThatContains(range.GetRange());
- if (entry) {
- ranges.Append(range.GetRange().GetRangeBase(),
- range.GetRange().GetByteSize(),
- CreateCoreFileMemoryRange(range));
- }
+ if (entry)
+ AddRegion(range, true, ranges);
}
}
|
|
✅ With the latest revision this PR passed the Python code formatter. |
clayborg
approved these changes
Feb 3, 2025
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
… checks as everyone else (llvm#125323) I encountered a `qMemoryRegionInfo not supported` error when capturing a Minidump. This was surprising, and I started looking around I found @jasonmolenda's fix in llvm#115963 and then realized I was not validated anything from the custom ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a
qMemoryRegionInfo not supportederror when capturing a Minidump. This was surprising, and I started looking around I found @jasonmolenda's fix in #115963 and then realized I was not validated anything from the custom ranges.