release/20.x: [Clang][ReleaseNotes] Document -fclang-abi-compat=19 re: #110503 #125368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#110503 updates the scope of `-fclang-abi-compat` but did not make that clear in the release notes. This PR addresses that problem.
hubert-reinterpretcast
requested review from
rjmccall,
AaronBallman and
VitaNuo
|
@llvm/pr-subscribers-clang Author: Hubert Tong (hubert-reinterpretcast) Changes#110503 updates the scope of Full diff: https://github.com/llvm/llvm-project/pull/125368.diff 1 Files Affected:
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 88c9fc8f95e4a1..53534d821b2c9a 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -252,7 +252,7 @@ ABI Changes in This Version
- Fixed Microsoft name mangling of placeholder, auto and decltype(auto), return types for MSVC 1920+. This change resolves incompatibilities with code compiled by MSVC 1920+ but will introduce incompatibilities with code compiled by earlier versions of Clang unless such code is built with the compiler option -fms-compatibility-version=19.14 to imitate the MSVC 1914 mangling behavior.
- Fixed the Itanium mangling of the construction vtable name. This change will introduce incompatibilities with code compiled by Clang 19 and earlier versions, unless the -fclang-abi-compat=19 option is used. (#GH108015)
-- Mangle member-like friend function templates as members of the enclosing class. (#GH110247, #GH110503)
+- Mangle member-like friend function templates as members of the enclosing class. This can be disabled using -fclang-abi-compat=19. (#GH110247, #GH110503)
AST Dumping Potentially Breaking Changes
----------------------------------------
|
tstellar
deleted the
users/hubert-reinterpretcast/llvm20-clang-release-notes-fclang-abi-compat-re110503
branch
|
Sorry, I didn't realize a review was requested on this. I usually merge release notes patches right away. I'll keep this in -rc1 and any follow up changes can be made for -rc2. |
|
It's approved anyway. Thanks, Tom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#110503 updates the scope of
-fclang-abi-compatbut did not make thatclear in the release notes. This PR addresses that problem.