Skip to content

[NVPTX] Avoid repeated map lookups (NFC) #127169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

[NVPTX] Avoid repeated map lookups (NFC) #127169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7600fc
[NVPTX] Avoid repeated map lookups (NFC)
kazutakahirata Feb 13, 2025
e8d3dbf
Address a comment.
kazutakahirata Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions llvm/lib/Target/NVPTX/NVPTXUtilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,18 @@ static std::optional<unsigned> findOneNVVMAnnotation(const GlobalValue *gv,
auto &AC = getAnnotationCache();
std::lock_guard<sys::Mutex> Guard(AC.Lock);
const Module *m = gv->getParent();
if (AC.Cache.find(m) == AC.Cache.end())
auto ACIt = AC.Cache.find(m);
if (ACIt == AC.Cache.end())
cacheAnnotationFromMD(m, gv);
else if (AC.Cache[m].find(gv) == AC.Cache[m].end())
else if (ACIt->second.find(gv) == ACIt->second.end())
cacheAnnotationFromMD(m, gv);
if (AC.Cache[m][gv].find(prop) == AC.Cache[m][gv].end())
// Look up AC.Cache[m][gv] again because cacheAnnotationFromMD may have
// inserted the entry.
auto &KVP = AC.Cache[m][gv];
auto It = KVP.find(prop);
if (It == KVP.end())
return std::nullopt;
return AC.Cache[m][gv][prop][0];
return It->second[0];
}

static bool findAllNVVMAnnotation(const GlobalValue *gv,
Expand All @@ -143,13 +148,18 @@ static bool findAllNVVMAnnotation(const GlobalValue *gv,
auto &AC = getAnnotationCache();
std::lock_guard<sys::Mutex> Guard(AC.Lock);
const Module *m = gv->getParent();
if (AC.Cache.find(m) == AC.Cache.end())
auto ACIt = AC.Cache.find(m);
if (ACIt == AC.Cache.end())
cacheAnnotationFromMD(m, gv);
else if (AC.Cache[m].find(gv) == AC.Cache[m].end())
else if (ACIt->second.find(gv) == ACIt->second.end())
cacheAnnotationFromMD(m, gv);
if (AC.Cache[m][gv].find(prop) == AC.Cache[m][gv].end())
// Look up AC.Cache[m][gv] again because cacheAnnotationFromMD may have
// inserted the entry.
auto &KVP = AC.Cache[m][gv];
auto It = KVP.find(prop);
if (It == KVP.end())
return false;
retval = AC.Cache[m][gv][prop];
retval = It->second;
return true;
}

Expand Down