[clangd][WIP] Add doxygen parsing for Hover #127451
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I try to revive clangd/clangd#529.
I applied this patch and rebased it to main.
Note: The original author of the patch is @tom-anders and there is this abandoned phabricator review.
In addition to applying the patch, I fixed the parsing of block commands with arguments to solve one of the open points of the issue.
I also changed the checks for specific commands from name to using the
comments::CommandInfo
to check whether a command is a brief or return command.This allows to handle all brief (e.g.
\brief
,\short
) and return (e.g.\return
,\returns
) the same without the need to check for all the command names individually.There was a merge conflict with #67802 which I solved without any failing tests but I am not sure yet if this is really correct.
According to @aaronliu0130 we also need to consider #78491 for this change which I did not do yet.