Skip to content

[clangd][WIP] Add doxygen parsing for Hover #127451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tcottin
Copy link

@tcottin tcottin commented Feb 17, 2025

With this PR I try to revive clangd/clangd#529.

I applied this patch and rebased it to main.

Note: The original author of the patch is @tom-anders and there is this abandoned phabricator review.

In addition to applying the patch, I fixed the parsing of block commands with arguments to solve one of the open points of the issue.
I also changed the checks for specific commands from name to using the comments::CommandInfo to check whether a command is a brief or return command.
This allows to handle all brief (e.g. \brief, \short) and return (e.g. \return, \returns) the same without the need to check for all the command names individually.

There was a merge conflict with #67802 which I solved without any failing tests but I am not sure yet if this is really correct.

According to @aaronliu0130 we also need to consider #78491 for this change which I did not do yet.

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@tcottin
Copy link
Author

tcottin commented Feb 24, 2025

closing this in favor of #128591

@tcottin tcottin closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant