Skip to content

[MLIR][LLVM] Fix import split marker in alias test #127540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

xlauko
Copy link
Contributor

@xlauko xlauko commented Feb 17, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Feb 17, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-llvm

Author: Henrich Lauko (xlauko)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/127540.diff

1 Files Affected:

  • (modified) mlir/test/Target/LLVMIR/Import/alias.ll (+5-5)
diff --git a/mlir/test/Target/LLVMIR/Import/alias.ll b/mlir/test/Target/LLVMIR/Import/alias.ll
index 9f86da3ecc71c..3ab68a7d8fb81 100644
--- a/mlir/test/Target/LLVMIR/Import/alias.ll
+++ b/mlir/test/Target/LLVMIR/Import/alias.ll
@@ -12,7 +12,7 @@ entry:
   ret ptr null
 }
 
-; -----
+; // -----
 
 @zed = global i32 42
 @foo = alias i32, ptr @zed
@@ -27,7 +27,7 @@ entry:
 ; CHECK:   llvm.return %[[ADDR]] : !llvm.ptr
 ; CHECK: }
 
-; -----
+; // -----
 
 @v1 = global i32 0
 @a3 = alias i32, addrspacecast (ptr @v1 to ptr addrspace(2))
@@ -37,7 +37,7 @@ entry:
 ; CHECK:   llvm.return %[[CASTED_ADDR]] : !llvm.ptr<2>
 ; CHECK: }
 
-; -----
+; // -----
 
 @some_name = constant { [3 x ptr] } { [3 x ptr] [ptr null, ptr null, ptr null] }
 @vtable = alias { [3 x ptr] }, ptr @some_name
@@ -47,7 +47,7 @@ entry:
 ; CHECK:   llvm.return %[[ADDR]] : !llvm.ptr
 ; CHECK: }
 
-; -----
+; // -----
 
 @glob.private = private constant [32 x i32] zeroinitializer
 @glob = linkonce_odr hidden alias [32 x i32], inttoptr (i64 add (i64 ptrtoint (ptr @glob.private to i64), i64 1234) to ptr)
@@ -60,7 +60,7 @@ entry:
 ; CHECK: %[[RET:.*]] = llvm.inttoptr %[[INTTOPTR]] : i64 to !llvm.ptr
 ; CHECK: llvm.return %[[RET]] : !llvm.ptr
 
-; -----
+; // -----
 
 @g1 = private global i32 0
 @g2 = internal constant ptr @a1

Copy link
Contributor

@gysit gysit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

LGTM

@xlauko xlauko merged commit 93a1184 into llvm:main Feb 17, 2025
11 checks passed
@xlauko xlauko deleted the xlauko/mlir-llvm-fix-import-split-marker branch February 17, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants