Skip to content

[MLIR][Affine] Fix affine.parallel op verifier #127611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions mlir/lib/Dialect/Affine/IR/AffineOps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3918,14 +3918,24 @@ LogicalResult AffineParallelOp::verify() {
}

unsigned expectedNumLBResults = 0;
for (APInt v : getLowerBoundsGroups())
expectedNumLBResults += v.getZExtValue();
for (APInt v : getLowerBoundsGroups()) {
unsigned results = v.getZExtValue();
if (results == 0)
return emitOpError()
<< "expected lower bound map to have at least one result";
expectedNumLBResults += results;
}
if (expectedNumLBResults != getLowerBoundsMap().getNumResults())
return emitOpError() << "expected lower bounds map to have "
<< expectedNumLBResults << " results";
unsigned expectedNumUBResults = 0;
for (APInt v : getUpperBoundsGroups())
expectedNumUBResults += v.getZExtValue();
for (APInt v : getUpperBoundsGroups()) {
unsigned results = v.getZExtValue();
if (results == 0)
return emitOpError()
<< "expected upper bound map to have at least one result";
expectedNumUBResults += results;
}
if (expectedNumUBResults != getUpperBoundsMap().getNumResults())
return emitOpError() << "expected upper bounds map to have "
<< expectedNumUBResults << " results";
Expand Down
18 changes: 18 additions & 0 deletions mlir/test/Dialect/Affine/invalid.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,24 @@ func.func @affine_parallel(%arg0 : index, %arg1 : index, %arg2 : index) {

// -----

func.func @no_upper_bound_affine_parallel() {
// expected-error@+1 {{expected lower bound map to have at least one result}}
affine.parallel (%arg2) = (max()) to (1) {
}
return
}

// -----

func.func @no_upper_bound_affine_parallel() {
// expected-error@+1 {{expected upper bound map to have at least one result}}
affine.parallel (%arg3) = (0) to (min()) {
}
return
}

// -----

func.func @vector_load_invalid_vector_type() {
%0 = memref.alloc() : memref<100xf32>
affine.for %i0 = 0 to 16 step 8 {
Expand Down