Skip to content

[libclc] Explicitly qualify private address spaces #127823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

[libclc] Explicitly qualify private address spaces #127823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libclc/generic/lib/math/ep_log.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
#define LF1 1.24999999978138668903e-02
#define LF2 2.23219810758559851206e-03

_CLC_DEF void __clc_ep_log(double x, int *xexp, double *r1, double *r2) {
_CLC_DEF void __clc_ep_log(double x, private int *xexp, private double *r1,
private double *r2) {
// Computes natural log(x). Algorithm based on:
// Ping-Tak Peter Tang
// "Table-driven implementation of the logarithm function in IEEE
Expand Down
3 changes: 2 additions & 1 deletion libclc/generic/lib/math/ep_log.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

#pragma OPENCL EXTENSION cl_khr_fp64 : enable

_CLC_DECL void __clc_ep_log(double x, int *xexp, double *r1, double *r2);
_CLC_DECL void __clc_ep_log(double x, private int *xexp, private double *r1,
private double *r2);

#endif
18 changes: 10 additions & 8 deletions libclc/generic/lib/math/modf.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,20 @@
#define ZERO 0.0h
#endif

_CLC_OVERLOAD _CLC_DEF __CLC_GENTYPE modf(__CLC_GENTYPE x, __CLC_GENTYPE *iptr) {
_CLC_OVERLOAD _CLC_DEF __CLC_GENTYPE modf(__CLC_GENTYPE x,
private __CLC_GENTYPE *iptr) {
*iptr = trunc(x);
return copysign(isinf(x) ? ZERO : x - *iptr, x);
}

#define MODF_DEF(addrspace) \
_CLC_OVERLOAD _CLC_DEF __CLC_GENTYPE modf(__CLC_GENTYPE x, addrspace __CLC_GENTYPE *iptr) { \
__CLC_GENTYPE private_iptr; \
__CLC_GENTYPE ret = modf(x, &private_iptr); \
*iptr = private_iptr; \
return ret; \
}
#define MODF_DEF(addrspace) \
_CLC_OVERLOAD _CLC_DEF __CLC_GENTYPE modf(__CLC_GENTYPE x, \
addrspace __CLC_GENTYPE *iptr) { \
__CLC_GENTYPE private_iptr; \
__CLC_GENTYPE ret = modf(x, &private_iptr); \
*iptr = private_iptr; \
return ret; \
}

MODF_DEF(local);
MODF_DEF(global);
Expand Down
24 changes: 14 additions & 10 deletions libclc/generic/lib/math/sincos_helpers.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ _CLC_DEF float __clc_tanf_piby4(float x, int regn) {
return regn & 1 ? tr : t;
}

_CLC_DEF void __clc_fullMulS(float *hi, float *lo, float a, float b, float bh,
float bt) {
_CLC_DEF void __clc_fullMulS(private float *hi, private float *lo, float a,
float b, float bh, float bt) {
if (HAVE_HW_FMA32()) {
float ph = a * b;
*hi = ph;
Expand All @@ -136,7 +136,7 @@ _CLC_DEF void __clc_fullMulS(float *hi, float *lo, float a, float b, float bh,
}
}

_CLC_DEF float __clc_removePi2S(float *hi, float *lo, float x) {
_CLC_DEF float __clc_removePi2S(private float *hi, private float *lo, float x) {
// 72 bits of pi/2
const float fpiby2_1 = (float)0xC90FDA / 0x1.0p+23f;
const float fpiby2_1_h = (float)0xC90 / 0x1.0p+11f;
Expand Down Expand Up @@ -174,7 +174,8 @@ _CLC_DEF float __clc_removePi2S(float *hi, float *lo, float x) {
return fnpi2;
}

_CLC_DEF int __clc_argReductionSmallS(float *r, float *rr, float x) {
_CLC_DEF int __clc_argReductionSmallS(private float *r, private float *rr,
float x) {
float fnpi2 = __clc_removePi2S(r, rr, x);
return (int)fnpi2 & 0x3;
}
Expand All @@ -188,7 +189,8 @@ _CLC_DEF int __clc_argReductionSmallS(float *r, float *rr, float x) {
HI = __clc_mul_hi(A, B); \
HI += LO < C

_CLC_DEF int __clc_argReductionLargeS(float *r, float *rr, float x) {
_CLC_DEF int __clc_argReductionLargeS(private float *r, private float *rr,
float x) {
int xe = (int)(as_uint(x) >> 23) - 127;
uint xm = 0x00800000U | (as_uint(x) & 0x7fffffU);

Expand Down Expand Up @@ -330,7 +332,7 @@ _CLC_DEF int __clc_argReductionLargeS(float *r, float *rr, float x) {
return ((i >> 1) + (i & 1)) & 0x3;
}

_CLC_DEF int __clc_argReductionS(float *r, float *rr, float x) {
_CLC_DEF int __clc_argReductionS(private float *r, private float *rr, float x) {
if (x < 0x1.0p+23f)
return __clc_argReductionSmallS(r, rr, x);
else
Expand All @@ -342,8 +344,9 @@ _CLC_DEF int __clc_argReductionS(float *r, float *rr, float x) {
#pragma OPENCL EXTENSION cl_khr_fp64 : enable

// Reduction for medium sized arguments
_CLC_DEF void __clc_remainder_piby2_medium(double x, double *r, double *rr,
int *regn) {
_CLC_DEF void __clc_remainder_piby2_medium(double x, private double *r,
private double *rr,
private int *regn) {
// How many pi/2 is x a multiple of?
const double two_by_pi = 0x1.45f306dc9c883p-1;
double dnpi2 = __clc_trunc(fma(x, two_by_pi, 0.5));
Expand Down Expand Up @@ -387,8 +390,9 @@ _CLC_DEF void __clc_remainder_piby2_medium(double x, double *r, double *rr,
// Return value "regn" tells how many lots of pi/2 were subtracted
// from x to put it in the range [-pi/4,pi/4], mod 4.

_CLC_DEF void __clc_remainder_piby2_large(double x, double *r, double *rr,
int *regn) {
_CLC_DEF void __clc_remainder_piby2_large(double x, private double *r,
private double *rr,
private int *regn) {

long ux = as_long(x);
int e = (int)(ux >> 52) - 1023;
Expand Down
12 changes: 7 additions & 5 deletions libclc/generic/lib/math/sincos_helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,18 @@
_CLC_DECL float __clc_sinf_piby4(float x, float y);
_CLC_DECL float __clc_cosf_piby4(float x, float y);
_CLC_DECL float __clc_tanf_piby4(float x, int y);
_CLC_DECL int __clc_argReductionS(float *r, float *rr, float x);
_CLC_DECL int __clc_argReductionS(private float *r, private float *rr, float x);

#ifdef cl_khr_fp64

#pragma OPENCL EXTENSION cl_khr_fp64 : enable

_CLC_DECL void __clc_remainder_piby2_medium(double x, double *r, double *rr,
int *regn);
_CLC_DECL void __clc_remainder_piby2_large(double x, double *r, double *rr,
int *regn);
_CLC_DECL void __clc_remainder_piby2_medium(double x, private double *r,
private double *rr,
private int *regn);
_CLC_DECL void __clc_remainder_piby2_large(double x, private double *r,
private double *rr,
private int *regn);
_CLC_DECL double2 __clc_sincos_piby4(double x, double xx);

#endif