PeepholeOpt: Immediately check if a reg_sequence compose supports a subregister #128279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubregister This is a quick fix for EXPENSIVE_CHECKS bot failures. I still think we could defer looking for a compatible subregister further up the use-def chain, and should be able to check compatibilty with the ultimate found source.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
ping |
perlfu
reviewed
Feb 25, 2025
| // TODO: Should we modify the register class to support the index? | ||
| const TargetRegisterClass *SrcRC = MRI.getRegClass(RegSeqInput.Reg); | ||
| const TargetRegisterClass *SrcWithSubRC = | ||
| TRI->getSubClassWithSubReg(SrcRC, ComposedDefInSrcReg1); |
There was a problem hiding this comment.
What is the return in the test case given?
Is it null -- is the comparison with the SrcRC important?
There was a problem hiding this comment.
Yes, the class matters:
Here it's SrcWithSubRC: DPR_VFP2 SrcRC: DPR. We would need to restrict the register class to the subclass with the subreg
qcolombet
approved these changes
Feb 25, 2025
arsenm
deleted the
users/arsenm/peephole-opt-check-regclass-supports-subreg-fix-expensive-checks
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/25/builds/6731 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for EXPENSIVE_CHECKS bot failures. I still think we could
defer looking for a compatible subregister further up the use-def chain, and
should be able to check compatibilty with the ultimate found source.