Skip to content

[llvm-diff] Diff attributes & metadata #129247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aapanfilovv
Copy link

Added diffing function, param, return attrs, metadata attach

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@tstellar tstellar requested a review from kazutakahirata March 1, 2025 15:23
@DavidSpickett DavidSpickett added the llvm-tools All llvm tools that do not have corresponding tag label Mar 3, 2025
@DavidSpickett
Copy link
Collaborator

That Buildkite failure will be fixed if you update your branch to be based on the latest changes from the main branch. It's not anything to do with your changes.

@kazutakahirata
Copy link
Contributor

@aapanfilovv Would you consider adding tests for your changes? It might be cumbersome to add as many tests as the number of if (Complain), but maybe you could add tests for some representative test cases!? Grep for llvm-diff under llvm/test for examples. Some of them create differences with cat and sed.

@aapanfilovv
Copy link
Author

@kazutakahirata Done, ping.

Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a minor comment about the line ending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-tools All llvm tools that do not have corresponding tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants