-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libc++] constexpr deque #129368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
changkhothuychung
wants to merge
15
commits into
llvm:main
Choose a base branch
from
changkhothuychung:constexpr-deque
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[libc++] constexpr deque #129368
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
171cd5a
constexpr deque
changkhothuychung caf34bf
use new macros
changkhothuychung 7e8a820
update test files to reflect constexpr
changkhothuychung 28f98a8
more files updated
changkhothuychung 00e3607
feature test macros
changkhothuychung 82e293b
fix FTM and constexpr macro
changkhothuychung 129f6d6
update more test files
changkhothuychung 7494b33
clang-format
changkhothuychung ed3b843
clang format
changkhothuychung 457ae75
add more macros
changkhothuychung 0b18391
Merge branch 'main' into constexpr-deque
changkhothuychung 3737499
fix ftm
changkhothuychung 5f9a116
fix version
changkhothuychung 630e5c5
update test files in deque.modifiers
changkhothuychung 5162d6c
fix test files in deque.special
changkhothuychung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frederick-vs-ja when trying to call the test in a constexpr case, via static_assert, I got error that
__annotate_new (0)
cannot be used in a constant expression, this function is called within a constexpr constructor. How should I handle this case? Can__annotate_new
be made constexpr ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think we can mark most underlying ASAN-related functions (which are not previously
constexpr
)_LIBCPP_CONSTEXPR_SINCE_CXX26
and addif (__libcpp_is_constant_evaluated()) return;
to suitable places.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frederick-vs-ja can you give me an example of where I can put
if (__libcpp_is_constant_evaluated()) return;
? I am not sure how I can apply that function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error messages look a bit chaotic. Could you try again after finish adding
_LIBCPP_CONSTEXPR_SINCE_CXX26
to<deque>
?