[CodeGen][NPM] Port MachineBlockPlacementStats to NPM #129853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2025
optimisan
force-pushed
the
users/optimisan/03-05-port-machine-block-placement
branch
from
316c784 to
4ce9005
Compare
optimisan
force-pushed
the
users/optimisan/05-03-port-mblock-placement-stats
branch
from
a01bc11 to
4a2d253
Compare
optimisan
force-pushed
the
users/optimisan/03-05-port-machine-block-placement
branch
from
4ce9005 to
e18d4c2
Compare
optimisan
force-pushed
the
users/optimisan/05-03-port-mblock-placement-stats
branch
from
4a2d253 to
10ddc68
Compare
optimisan
force-pushed
the
users/optimisan/05-03-port-mblock-placement-stats
branch
from
10ddc68 to
a960e88
Compare
arsenm
approved these changes
Mar 12, 2025
arsenm
reviewed
Mar 12, 2025
| public: | ||
| PreservedAnalyses run(MachineFunction &MF, | ||
| MachineFunctionAnalysisManager &MFAM); | ||
| static bool isRequired() { return true; } |
There was a problem hiding this comment.
It seems like this should not be required for analyse
There was a problem hiding this comment.
This keeps it consistent with the legacy pass not skipping optnone functions
There was a problem hiding this comment.
This pass just updates statistics? It certainly shouldn't be considered required. It pre-checks isFunctionInPrintList. Should the PM be directly managing this case?
There was a problem hiding this comment.
The pass instrumentation checks for isFunctionInPrintList but it is independent of the Statistic object.
optnone is also separate from isFunctionInPrintList, so I think this should be not skipped
Base automatically changed from
users/optimisan/03-05-port-machine-block-placement
to
main
March 14, 2025 05:01
optimisan
force-pushed
the
users/optimisan/05-03-port-mblock-placement-stats
branch
from
a960e88 to
ffc6bed
Compare
optimisan
force-pushed
the
users/optimisan/05-03-port-mblock-placement-stats
branch
from
ffc6bed to
434625b
Compare
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.