Skip to content

[ADT] Use adl_being/end in concat #130520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions llvm/include/llvm/ADT/STLExtras.h
Original file line number Diff line number Diff line change
Expand Up @@ -1112,8 +1112,8 @@ class concat_iterator
/// We need the full range to know how to switch between each of the
/// iterators.
template <typename... RangeTs>
explicit concat_iterator(RangeTs &&... Ranges)
: Begins(std::begin(Ranges)...), Ends(std::end(Ranges)...) {}
explicit concat_iterator(RangeTs &&...Ranges)
: Begins(adl_begin(Ranges)...), Ends(adl_end(Ranges)...) {}

using BaseT::operator++;

Expand Down Expand Up @@ -1142,26 +1142,25 @@ template <typename ValueT, typename... RangeTs> class concat_range {
public:
using iterator =
concat_iterator<ValueT,
decltype(std::begin(std::declval<RangeTs &>()))...>;
decltype(adl_begin(std::declval<RangeTs &>()))...>;

private:
std::tuple<RangeTs...> Ranges;

template <size_t... Ns>
iterator begin_impl(std::index_sequence<Ns...>) {
template <size_t... Ns> iterator begin_impl(std::index_sequence<Ns...>) {
return iterator(std::get<Ns>(Ranges)...);
}
template <size_t... Ns>
iterator begin_impl(std::index_sequence<Ns...>) const {
return iterator(std::get<Ns>(Ranges)...);
}
template <size_t... Ns> iterator end_impl(std::index_sequence<Ns...>) {
return iterator(make_range(std::end(std::get<Ns>(Ranges)),
std::end(std::get<Ns>(Ranges)))...);
return iterator(make_range(adl_end(std::get<Ns>(Ranges)),
adl_end(std::get<Ns>(Ranges)))...);
}
template <size_t... Ns> iterator end_impl(std::index_sequence<Ns...>) const {
return iterator(make_range(std::end(std::get<Ns>(Ranges)),
std::end(std::get<Ns>(Ranges)))...);
return iterator(make_range(adl_end(std::get<Ns>(Ranges)),
adl_end(std::get<Ns>(Ranges)))...);
}

public:
Expand Down
10 changes: 10 additions & 0 deletions llvm/unittests/ADT/STLExtrasTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,16 @@ TEST(STLExtrasTest, ConcatRange) {
EXPECT_EQ(Expected, Test);
}

TEST(STLExtrasTest, ConcatRangeADL) {
// Make sure that we use the `begin`/`end` functions from `some_namespace`,
// using ADL.
some_namespace::some_struct S0;
S0.data = {1, 2};
some_namespace::some_struct S1;
S1.data = {3, 4};
EXPECT_THAT(concat<const int>(S0, S1), ElementsAre(1, 2, 3, 4));
}

template <typename T> struct Iterator {
int i = 0;
T operator*() const { return i; }
Expand Down
Loading