[clang] Handle Binary StingLiteral kind in one more place #132201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bots are upset by llvm#127629 . Fix that.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) ChangesThe bots are upset by #127629 . Fix that. Full diff: https://github.com/llvm/llvm-project/pull/132201.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index f085facf7ff55..8f204b949cb2c 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -4143,6 +4143,7 @@ Sema::IsStringLiteralToNonConstPointerConversion(Expr *From, QualType ToType) {
// We don't allow UTF literals to be implicitly converted
break;
case StringLiteralKind::Ordinary:
+ case StringLiteralKind::Binary:
return (ToPointeeType->getKind() == BuiltinType::Char_U ||
ToPointeeType->getKind() == BuiltinType::Char_S);
case StringLiteralKind::Wide:
|
Fznamznon
commented
Mar 20, 2025
| @@ -4143,6 +4143,7 @@ Sema::IsStringLiteralToNonConstPointerConversion(Expr *From, QualType ToType) { | |||
| // We don't allow UTF literals to be implicitly converted | |||
| break; | |||
| case StringLiteralKind::Ordinary: | |||
| case StringLiteralKind::Binary: | |||
There was a problem hiding this comment.
That just brings to the state of before the patch with Binary literal. It seems the code is C++-specific, so I'm not sure what are the implications and if #embed can end up in the situation at all. Let me know if it better to revert the whole thing and think a bit more about it.
AaronBallman
approved these changes
Mar 20, 2025
Fznamznon
added a commit
to Fznamznon/llvm-project
that referenced
this pull request
Mar 28, 2025
The bots are upset by llvm#127629 . Fix that.
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 14, 2025
The bots are upset by llvm#127629 . Fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bots are upset by #127629 . Fix that.