[flang] Fix slp-vectorize.f90 test

[mrkajetanp]

The test was missing "-o /dev/null" and inadvertently generating a .ll file in the test directory.

[llvmbot]

@llvm/pr-subscribers-flang-driver

Author: Kajetan Puchalski (mrkajetanp)

Changes

The test was missing "-o /dev/null" and inadvertently generating a .ll file in the test directory.

---

Full diff: https://github.com/llvm/llvm-project/pull/133128.diff

1 Files Affected:

• (modified) flang/test/Driver/slp-vectorize.f90 (+2-2)

diff --git a/flang/test/Driver/slp-vectorize.f90 b/flang/test/Driver/slp-vectorize.f90
index 28004f5c91f5f..1ebbd25e47a55 100644
--- a/flang/test/Driver/slp-vectorize.f90
+++ b/flang/test/Driver/slp-vectorize.f90
@@ -6,8 +6,8 @@
 ! RUN: %flang -### -S -O3 %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZE %s
 ! RUN: %flang -### -S -Os %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZE %s
 ! RUN: %flang -### -S -Oz %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZE %s
-! RUN: %flang_fc1 -emit-llvm -O2 -vectorize-slp -mllvm -print-pipeline-passes %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZER %s
-! RUN: %flang_fc1 -emit-llvm -O2 -mllvm -print-pipeline-passes %s 2>&1 | FileCheck -check-prefix=CHECK-NO-SLP-VECTORIZER %s
+! RUN: %flang_fc1 -emit-llvm -O2 -vectorize-slp -mllvm -print-pipeline-passes -o /dev/null %s 2>&1 | FileCheck -check-prefix=CHECK-SLP-VECTORIZER %s
+! RUN: %flang_fc1 -emit-llvm -O2 -mllvm -print-pipeline-passes -o /dev/null %s 2>&1 | FileCheck -check-prefix=CHECK-NO-SLP-VECTORIZER %s
 ! CHECK-SLP-VECTORIZE: "-vectorize-slp"
 ! CHECK-NO-SLP-VECTORIZE-NOT: "-no-vectorize-slp"
 ! CHECK-SLP-VECTORIZER: slp-vectorizer

[tblah]

Merging without review because this is affecting a buildbot #132801 (comment)

I can see other flang tests using -o /dev/null without disabling Windows so hopefully this works.

[DanielCChen]

@mrkajetanp
Both AIX and LoP buildbot failed LIT tests when check-flang as

********************
Unresolved Tests (1):
  Flang :: Driver/slp-vectorize.ll

https://lab.llvm.org/buildbot/#/builders/157/builds/23695

Not sure why it shows slp-vectorize.ll instead of slp-vectorize.f90.

[mrkajetanp]

@mrkajetanp
Both AIX and LoP buildbot failed LIT tests when check-flang as

********************
Unresolved Tests (1):
  Flang :: Driver/slp-vectorize.ll

https://lab.llvm.org/buildbot/#/builders/157/builds/23695

Not sure why it shows slp-vectorize.ll instead of slp-vectorize.f90.

Prior to this commit the test was generating a .ll file in the test directory, which the runners would later pick up and fail on. With -o /dev/null this no longer happens, so maybe the runner has some cached leftovers or something like that? I'm not sure what exactly Unresolved Tests means in this context.

[DanielCChen]

Right. It seems like the .ll file from the previous run before the fix is still there. We are trying to see if a clean build can remove it.

[tarunprabhu]

I'm not sure what exactly Unresolved Tests means in this context.

@mrkajetanp, You will usually see that error when lit does not know what to do with a file, typically because it has no RUN directives. If you look at the log from the buildbot that @DanielCChen linked to, you will find this:

******************** TEST 'Flang :: Driver/slp-vectorize.ll' FAILED ********************
Test has no 'RUN:' line
********************

[mrkajetanp]

@mrkajetanp, You will usually see that error when lit does not know what to do with a file, typically because it has no RUN directives. If you look at the log from the buildbot that @DanielCChen linked to, you will find this:

******************** TEST 'Flang :: Driver/slp-vectorize.ll' FAILED ********************
Test has no 'RUN:' line
********************

Ah thanks, makes sense! Apologies for the confusion this has caused, I'll be more careful with the build bots going forward..