Skip to content

[NFC][OpenMP] Address coverity hit regarding unintended integer overflow #133324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[NFC][OpenMP] Address coverity hit regarding unintended integer overflow #133324

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cfce99
[NFC][OpenMP] Address coverity hit regarding unintended integer overflow
hansangbae Mar 18, 2025
734438d
Merge branch 'llvm:main' into 20250319-address-coverity-hit
hansangbae Mar 25, 2025
479f7b0
Merge branch 'llvm:main' into 20250319-address-coverity-hit
hansangbae Mar 27, 2025
bfe3b0a
Merge branch 'llvm:main' into 20250319-address-coverity-hit
hansangbae Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions openmp/runtime/src/kmp_collapse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,11 @@ bool kmp_calc_one_iv_XX(const bounds_infoXX_template<T> *bounds,
if (start_with_lower_bound) {
// we moved to the next iteration on one of outer loops, should start
// with the lower bound here:
temp = bounds->lb0 + bounds->lb1 * outer_iv;
temp = bounds->lb0 + static_cast<kmp_uint64>(bounds->lb1) * outer_iv;
} else {
auto iteration = iterations[ind];
temp = bounds->lb0 + bounds->lb1 * outer_iv + iteration * bounds->step;
temp = bounds->lb0 + static_cast<kmp_uint64>(bounds->lb1) * outer_iv +
iteration * bounds->step;
}

// Now trim original iv according to its type:
Expand Down Expand Up @@ -831,14 +832,15 @@ kmp_calc_number_of_iterations_XX(const bounds_infoXX_template<T> *bounds,
kmp_loop_nest_iv_t iterations = 0;

if (bounds->comparison == comparison_t::comp_less_or_eq) {
iterations =
(static_cast<T>(original_ivs[ind]) - bounds->lb0 -
bounds->lb1 * static_cast<T>(original_ivs[bounds->outer_iv])) /
__kmp_abs(bounds->step);
iterations = (static_cast<T>(original_ivs[ind]) - bounds->lb0 -
static_cast<kmp_loop_nest_iv_t>(bounds->lb1) *
static_cast<T>(original_ivs[bounds->outer_iv])) /
__kmp_abs(bounds->step);
} else {
KMP_DEBUG_ASSERT(bounds->comparison == comparison_t::comp_greater_or_eq);
iterations = (bounds->lb0 +
bounds->lb1 * static_cast<T>(original_ivs[bounds->outer_iv]) -
static_cast<kmp_loop_nest_iv_t>(bounds->lb1) *
static_cast<T>(original_ivs[bounds->outer_iv]) -
static_cast<T>(original_ivs[ind])) /
__kmp_abs(bounds->step);
}
Expand Down