Skip to content

[KeyInstr] Complex assignment atoms #134638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 27, 2025
Merged

[KeyInstr] Complex assignment atoms #134638

merged 10 commits into from
May 27, 2025

Conversation

OCHyams
Copy link
Contributor

@OCHyams OCHyams commented Apr 7, 2025

This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.

The Key Instructions project is introduced, including a "quick summary" section
at the top which adds context for this PR, here:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

The feature is only functional in LLVM if LLVM is built with CMake flag
LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.

The Clang-side work is demoed here:
#130943

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:codegen IR generation bugs: mangling, exceptions, etc. labels Apr 7, 2025
Copy link
Contributor Author

OCHyams commented Apr 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@OCHyams
Copy link
Contributor Author

OCHyams commented May 23, 2025

Sorry to all that were added... grappling with messed-up graphite internal state, GitHub enjoys adding reviewers for me when I change base.

OCHyams added 8 commits May 23, 2025 15:00
This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.

The Key Instructions project is introduced, including a "quick summary" section
at the top which adds context for this PR, here:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

The feature is only functional in LLVM if LLVM is built with CMake flag
LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.

The Clang-side work is demoed here:
#130943
@OCHyams OCHyams force-pushed the users/OCHyams/ki-clang-complex branch from ebd8acd to 70856b8 Compare May 23, 2025 15:57
@OCHyams
Copy link
Contributor Author

OCHyams commented May 23, 2025

Sorry I misunderstood what you were saying. Fixed, this should now have symmetry with prior patches. Expanded the test coverage. There's 4 binop assign calls that are instrumented individually which reflects the previous patch's macro usage. The expanded test coverage identified a redundant atom group nesting, which is now also fixed (and could only be fixed with the symmetrical approach, hurray). Thanks for the keen eyed review!

Copy link
Member

@jmorse jmorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCHyams OCHyams merged commit 059885c into main May 27, 2025
6 of 11 checks passed
@OCHyams OCHyams deleted the users/OCHyams/ki-clang-complex branch May 27, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants