[CMake] Configure ccache using command line options #134857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ccache 4.8, it is possible to pass configuration options directly to ccache on the command line as opposed to through environment variables. This is the intended way for CMake to configure ccache, as described on the GitHub wiki for the project: https://github.com/ccache/ccache/wiki/CMake This should allow for uniform ccache configuration that does not rely on platform-specific environment setup. Rework the way ccache is configured by LLVM accordingly. Signed-off-by: Kajetan Puchalski <[email protected]>
mrkajetanp
requested review from
mstorsjo,
mgorny,
petrhosek,
DavidTruby,
Meinersbur,
tblah and
thesamesam
DavidTruby
approved these changes
Apr 8, 2025
|
As suggested, reposting the changes to how we configure ccache on their own. This should be a non-functional change for Linux, but for Windows it should enable us to configure ccache in cases where previously we'd error with |
mrkajetanp
force-pushed
the
cmake-ccache-refactor
branch
from
8199b45 to
7d7d282
Compare
|
I've checked this on Windows as well and it looks like it works there too. Thanks! |
petrhosek
reviewed
Apr 9, 2025
|
Given that this is effectively the same as what was previously agreed on but with the shortcomings fixed, should we just give it a try to have it run through the buildbots? |
petrhosek
approved these changes
Apr 14, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/117/builds/8684 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/7/builds/13411 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/10418 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/16303 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/16292 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/54/builds/8251 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/155/builds/8386 Here is the relevant piece of the build log for the reference |
mrkajetanp
added a commit
that referenced
this pull request
Apr 14, 2025
This reverts commit 904f1b1.
mrkajetanp
added a commit
that referenced
this pull request
Apr 14, 2025
|
Nope, had to revert again. I think what's happening is that on some of those Windows machines if neither LLVM_CCACHE_MAXSIZE nor LLVM_CCACHE_DIR are set, then LLVM_CCACHE_PARAMS stays like what it is set to in the snippet below and turns into "C:\ninja\ccache.exe run_second_cpp=true hash_dir=true" as opposed to that but without surrounding quotemarks which is what we want. I'm not sure how to reliably get around this while keeping LLVM_CCACHE_PARAMS as a CACHE STRING as opposed to making it into a list from the get-go. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/14857 Here is the relevant piece of the build log for the reference |
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
Since ccache 4.8, it is possible to pass configuration options directly to ccache on the command line as opposed to through environment variables. This is the intended way for CMake to configure ccache, as described on the GitHub wiki for the project: https://github.com/ccache/ccache/wiki/CMake This should allow for uniform ccache configuration that does not rely on platform-specific environment setup. Rework the way ccache is configured by LLVM accordingly. --------- Signed-off-by: Kajetan Puchalski <[email protected]>
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
|
Does anyone have thoughts on which direction we should take this in? If we can't reliably configure ccache on Windows, should we just disable precompiled headers for Windows ccache builds and roll them out only for Linux for the time being? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ccache 4.8, it is possible to pass configuration options directly to ccache on the command line as opposed to through environment variables.
This is the intended way for CMake to configure ccache, as described on the GitHub wiki for the project:
https://github.com/ccache/ccache/wiki/CMake
This should allow for uniform ccache configuration that does not rely on platform-specific environment setup.
Rework the way ccache is configured by LLVM accordingly.