Skip to content

[libc++] A quick-fix for the Apple CI. #135202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

[libc++] A quick-fix for the Apple CI. #135202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...est/libcxx/input.output/iostreams.base/ios.base/ios.base.cons/dtor.uninitialized.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// UNSUPPORTED: no-exceptions

// The fix for issue 57964 requires an updated dylib due to explicit
// instantiations. That means Apple backdeployment targets remain broken.
// XFAIL: using-built-library-before-llvm-19
// XFAIL using-built-library-before-llvm-19

// <ios>

Expand Down
5 changes: 4 additions & 1 deletion libcxx/test/std/input.output/file.streams/fstreams/filebuf.virtuals/setbuf.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// <fstream>

// basic_streambuf<charT, traits>* setbuf(char_type* s, streamsize n) override;

// This test requires the fix to https://github.com/llvm/llvm-project/issues/60509 in the dylib,
// which landed in 5afb937d8a30445642ccaf33866ee4cdd0713222.
// XFAIL: using-built-library-before-llvm-19
// XFAIL using-built-library-before-llvm-19

#include <fstream>
#include <cstddef>
Expand Down
5 changes: 4 additions & 1 deletion libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/sync.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,17 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// <istream>

// int sync();

// The fix for bug 51497 and bug 51499 require and updated dylib due to
// explicit instantiations. That means Apple backdeployment targets remain
// broken.
// XFAIL: using-built-library-before-llvm-19
// XFAIL using-built-library-before-llvm-19

#include <istream>
#include <cassert>
Expand Down
3 changes: 3 additions & 0 deletions ...td/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// Bionic has minimal locale support, investigate this later.
// XFAIL: LIBCXX-ANDROID-FIXME

Expand Down
5 changes: 4 additions & 1 deletion ...ategory.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
//
//===----------------------------------------------------------------------===//

// XFAIL: darwin
// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// XFAIL darwin

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd
Expand Down
3 changes: 3 additions & 0 deletions ...ategory.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd

Expand Down
5 changes: 4 additions & 1 deletion ...ategory.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd

Expand Down
5 changes: 4 additions & 1 deletion ...ategory.monetary/locale.money.put/locale.money.put.members/put_long_double_fr_FR.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@
//
//===----------------------------------------------------------------------===//

// XFAIL: darwin
// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// XFAIL darwin

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd
Expand Down
3 changes: 3 additions & 0 deletions ...ategory.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd

Expand Down
5 changes: 4 additions & 1 deletion ...ategory.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd

Expand Down
5 changes: 4 additions & 1 deletion ...ization/locale.categories/category.monetary/locale.moneypunct.byname/curr_symbol.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd

Expand Down
7 changes: 5 additions & 2 deletions ...calization/locale.categories/category.monetary/locale.moneypunct.byname/grouping.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// XFAIL: darwin

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// XFAIL darwin
//
// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd
Expand Down
5 changes: 4 additions & 1 deletion ...lization/locale.categories/category.monetary/locale.moneypunct.byname/neg_format.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_MONETARY at the moment
// XFAIL: netbsd

Expand Down
5 changes: 4 additions & 1 deletion ...cale.categories/category.numeric/locale.num.get/facet.num.get.members/get_double.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// The fix for LWG2381 (https://github.com/llvm/llvm-project/pull/77948) changed behavior of
// FP parsing. This requires 3e15c97fa3812993bdc319827a5c6d867b765ae8 in the dylib.
// XFAIL: using-built-library-before-llvm-19
// XFAIL using-built-library-before-llvm-19

// <locale>

Expand Down
5 changes: 4 additions & 1 deletion ...ocale.categories/category.numeric/locale.num.get/facet.num.get.members/get_float.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// The fix for LWG2381 (https://github.com/llvm/llvm-project/pull/77948) changed behavior of
// FP parsing. This requires 3e15c97fa3812993bdc319827a5c6d867b765ae8 in the dylib.
// XFAIL: using-built-library-before-llvm-19
// XFAIL using-built-library-before-llvm-19

// <locale>

Expand Down
5 changes: 4 additions & 1 deletion ...categories/category.numeric/locale.num.get/facet.num.get.members/get_long_double.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// The fix for LWG2381 (https://github.com/llvm/llvm-project/pull/77948) changed behavior of
// FP parsing. This requires 3e15c97fa3812993bdc319827a5c6d867b765ae8 in the dylib.
// XFAIL: using-built-library-before-llvm-19
// XFAIL using-built-library-before-llvm-19

// <locale>

Expand Down
5 changes: 4 additions & 1 deletion ...td/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_NUMERIC at the moment
// XFAIL: netbsd

Expand Down
3 changes: 3 additions & 0 deletions ...calization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// NetBSD does not support LC_NUMERIC at the moment
// XFAIL: netbsd

Expand Down
3 changes: 3 additions & 0 deletions libcxx/test/std/time/time.duration/time.duration.nonmember/ostream.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: no-localization
// UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
Expand Down
3 changes: 3 additions & 0 deletions libcxx/test/std/time/time.syn/formatter.duration.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: no-localization
// UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
Expand Down
3 changes: 3 additions & 0 deletions libcxx/test/std/time/time.syn/formatter.file_time.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: no-localization
// UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
Expand Down
3 changes: 3 additions & 0 deletions libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: no-localization
// UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
Expand Down
3 changes: 3 additions & 0 deletions libcxx/test/std/time/time.syn/formatter.local_time.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: no-localization
// UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
Expand Down
3 changes: 3 additions & 0 deletions libcxx/test/std/time/time.syn/formatter.sys_time.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

// TODO(mordante) Investigate
// UNSUPPORTED: apple-clang

// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: no-localization
// UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
Expand Down
1 change: 1 addition & 0 deletions libcxx/utils/generate_feature_test_macro_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
)
import functools
import json
from libcxx.header_information import module_c_headers, module_headers, header_restrictions, headers_not_available, libcxx_root


def get_libcxx_paths():
Expand Down
Loading