Skip to content

[CI] enable code-format-helper for .cl files #135748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

wenju-he
Copy link
Contributor

In clang-format, OpenCL .cl file uses default C++ formatting. There are many pull-requests in libclc project that change OpenCL files. It is beneficial to enable clang-format for them in CI.

In clang-format, OpenCL .cl file uses default C++ formatting.
There are many pull-requests in libclc project that change OpenCL files.
It is beneficial to enable clang-format for them in CI.
Copy link

github-actions bot commented Apr 15, 2025

✅ With the latest revision this PR passed the Python code formatter.

@wenju-he
Copy link
Contributor Author

@frasercrmck please help to review. thanks.

Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frasercrmck frasercrmck merged commit cf2399a into llvm:main Apr 16, 2025
11 checks passed
@wenju-he wenju-he deleted the code-format-helper.py-cl branch April 16, 2025 12:09
var-const pushed a commit to ldionne/llvm-project that referenced this pull request Apr 17, 2025
In clang-format, OpenCL .cl file uses default C++ formatting. There are
many pull-requests in libclc project that change OpenCL files. It is
beneficial to enable clang-format for them in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants