[BOLT] Fix conditional compilation of hugify.cpp #135880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix builds after llvm#117158: do not build hugify.cpp on Apple platforms.
maksfb
requested review from
aaupov,
rafaelauler,
ayermolo,
dcci and
yota9
as code owners
|
@llvm/pr-subscribers-bolt Author: Maksim Panchenko (maksfb) ChangesFix builds after #117158: do not build hugify.cpp on Apple platforms. Full diff: https://github.com/llvm/llvm-project/pull/135880.diff 1 Files Affected:
diff --git a/bolt/runtime/hugify.cpp b/bolt/runtime/hugify.cpp
index 67d5fa26007d2..672b04247dfa4 100644
--- a/bolt/runtime/hugify.cpp
+++ b/bolt/runtime/hugify.cpp
@@ -6,8 +6,8 @@
//
//===---------------------------------------------------------------------===//
-#if defined(__x86_64__) || \
- (defined(__aarch64__) || defined(__arm64__)) && !defined(__APPLE__)
+#if (defined(__x86_64__) || defined(__aarch64__) || defined(__arm64__)) && \
+ !defined(__APPLE__)
#include "common.h"
|
ilovepi
approved these changes
Apr 15, 2025
No worries, Paul! I didn't verify the fix since I don't build on Mac, but that macro is the most likely cause. |
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
Fix builds after llvm#117158: do not build hugify.cpp on Apple platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix builds after #117158: do not build hugify.cpp on Apple platforms.