Skip to content

[NFC] Clarify the syntax of passes flag #136175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

hiraditya
Copy link
Collaborator

No description provided.

@hiraditya hiraditya requested review from omern1 and nico April 17, 2025 18:19
@hiraditya
Copy link
Collaborator Author

cc: @amordo

@amordo
Copy link
Contributor

amordo commented Apr 17, 2025

I'd add an example how multiple passes should be written, because -passes=foo,bar also invalid; the right one is -passes="foo,bar"

Copy link
Member

@omern1 omern1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiraditya hiraditya merged commit 715b1d5 into llvm:main Apr 25, 2025
11 checks passed
@hiraditya hiraditya deleted the opt_doc branch April 25, 2025 13:18
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants