[BOLT][heatmap] Use parsed basic/branch events #136531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Created using spr 1.3.4 [skip ci]
aaupov
changed the base branch from
users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events
to
main
Created using spr 1.3.4 [skip ci]
aaupov
changed the base branch from
main
to
users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events
Created using spr 1.3.4 [skip ci]
aaupov
changed the base branch from
users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events
to
users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events-1
aaupov
changed the title
aaupov
changed the title
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
aaupov
changed the title
Created using spr 1.3.4
aaupov
requested review from
maksfb,
rafaelauler,
ayermolo and
yota9
as code owners
aaupov
changed the title
aaupov
changed the title
Created using spr 1.3.4 [skip ci]
maksfb
approved these changes
May 13, 2025
There should be no. I tested one binary/perf.data pair and the heatmaps were identical (rafaelauler/bolt-tests@0868850) |
aaupov
changed the base branch from
users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events-1
to
main
aaupov
changed the base branch from
main
to
users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events-1
Created using spr 1.3.4 [skip ci]
aaupov
changed the base branch from
users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events-1
to
main
aaupov
deleted the
users/aaupov/spr/boltnfci-switch-heatmap-to-using-parsed-basicbranch-events
branch
aaupov
added a commit
that referenced
this pull request
May 13, 2025
Reuse data structures used by perf data reader for pre-aggregated data. Combined with #136531 this allows using pre-aggregated data for heatmap. Test Plan: heatmap-preagg.test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate profile parsing in heatmap construction, switching to
using parsed profile. #138798 adds support for using pre-aggregated
profile for heatmap construction.
Test Plan: added heatmap.test in rafaelauler/bolt-tests@0868850