Skip to content

[libclc][NFC] Remove unary_builtin.inc #137656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

frasercrmck
Copy link
Contributor

We had two ways of achieving the same thing. This commit removes unary_builtin.inc in favour of the approach combining gentype.inc with unary_def.inc.

There is no change to the codegen for any target.

We had two ways of achieving the same thing. This commit removes
unary_builtin.inc in favour of the approach combining gentype.inc with
unary_def.inc.

There is no change to the codegen for any target.
@frasercrmck frasercrmck added the libclc libclc OpenCL library label Apr 28, 2025
@frasercrmck frasercrmck requested a review from arsenm April 28, 2025 15:52
@frasercrmck frasercrmck merged commit 837d5a7 into llvm:main Apr 29, 2025
11 checks passed
@frasercrmck frasercrmck deleted the libclc-remove-unary-builtin-inc branch April 29, 2025 13:17
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
We had two ways of achieving the same thing. This commit removes
unary_builtin.inc in favour of the approach combining gentype.inc with
unary_def.inc.

There is no change to the codegen for any target.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
We had two ways of achieving the same thing. This commit removes
unary_builtin.inc in favour of the approach combining gentype.inc with
unary_def.inc.

There is no change to the codegen for any target.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
We had two ways of achieving the same thing. This commit removes
unary_builtin.inc in favour of the approach combining gentype.inc with
unary_def.inc.

There is no change to the codegen for any target.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
We had two ways of achieving the same thing. This commit removes
unary_builtin.inc in favour of the approach combining gentype.inc with
unary_def.inc.

There is no change to the codegen for any target.
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
We had two ways of achieving the same thing. This commit removes
unary_builtin.inc in favour of the approach combining gentype.inc with
unary_def.inc.

There is no change to the codegen for any target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libclc libclc OpenCL library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants