-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[lldb-dap] Adding an icon to the lldb-dap package. #137695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image.
@llvm/pr-subscribers-lldb Author: John Harrison (ashgti) ChangesThis shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image. Here is what this looks like locally: Full diff: https://github.com/llvm/llvm-project/pull/137695.diff 3 Files Affected:
diff --git a/lldb/tools/lldb-dap/.vscodeignore b/lldb/tools/lldb-dap/.vscodeignore
index 0491ba879fc3f..511bbf3d08399 100644
--- a/lldb/tools/lldb-dap/.vscodeignore
+++ b/lldb/tools/lldb-dap/.vscodeignore
@@ -5,5 +5,6 @@
!LICENSE.TXT
!package.json
!README.md
+!llvm-logo.png
!out/**
-!syntaxes/**
+!syntaxes/**
\ No newline at end of file
diff --git a/lldb/tools/lldb-dap/llvm-logo.png b/lldb/tools/lldb-dap/llvm-logo.png
new file mode 100644
index 0000000000000..039e8d67931c6
Binary files /dev/null and b/lldb/tools/lldb-dap/llvm-logo.png differ
diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json
index 1ef42b4a0d95c..a0230421814e9 100644
--- a/lldb/tools/lldb-dap/package.json
+++ b/lldb/tools/lldb-dap/package.json
@@ -14,6 +14,7 @@
"bugs": {
"url": "https://github.com/llvm/llvm-project/issues"
},
+ "icon": "llvm-logo.png",
"keywords": [
"C",
"C++",
|
Resolves #137294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wish we had a logo for LLDB that we could use for this, but this is a good solution until/if that ever changes.
This shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image. Here is what this looks like locally: <img width="1020" alt="Screenshot 2025-04-28 at 12 30 33 PM" src="https://github.com/user-attachments/assets/cd615161-06db-4a37-8f8a-df65ca620a67" />
This shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image. Here is what this looks like locally: <img width="1020" alt="Screenshot 2025-04-28 at 12 30 33 PM" src="https://github.com/user-attachments/assets/cd615161-06db-4a37-8f8a-df65ca620a67" />
This shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image. Here is what this looks like locally: <img width="1020" alt="Screenshot 2025-04-28 at 12 30 33 PM" src="https://github.com/user-attachments/assets/cd615161-06db-4a37-8f8a-df65ca620a67" />
This shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image. Here is what this looks like locally: <img width="1020" alt="Screenshot 2025-04-28 at 12 30 33 PM" src="https://github.com/user-attachments/assets/cd615161-06db-4a37-8f8a-df65ca620a67" />
This shows up in the extension UI and in the VSCode extension marketplace. I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image. Here is what this looks like locally: <img width="1020" alt="Screenshot 2025-04-28 at 12 30 33 PM" src="https://github.com/user-attachments/assets/cd615161-06db-4a37-8f8a-df65ca620a67" />
This shows up in the extension UI and in the VSCode extension marketplace.
I used the llvm/llvm-www/blob/main/img/LLVMWyvernSmall.png for the image.
Here is what this looks like locally:
