[SPARC] Add llvm-readobj support, update ELF reloc types and dynamic tags. #137916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-objectyaml @llvm/pr-subscribers-llvm-binary-utilities Author: Alex Rønne Petersen (alexrp) ChangesSourced from binutils. Full diff: https://github.com/llvm/llvm-project/pull/137916.diff 1 Files Affected:
diff --git a/llvm/include/llvm/BinaryFormat/ELFRelocs/Sparc.def b/llvm/include/llvm/BinaryFormat/ELFRelocs/Sparc.def
index 7e01a4a8a0a06..9f10310442fa4 100644
--- a/llvm/include/llvm/BinaryFormat/ELFRelocs/Sparc.def
+++ b/llvm/include/llvm/BinaryFormat/ELFRelocs/Sparc.def
@@ -87,3 +87,12 @@ ELF_RELOC(R_SPARC_GOTDATA_LOX10, 81)
ELF_RELOC(R_SPARC_GOTDATA_OP_HIX22, 82)
ELF_RELOC(R_SPARC_GOTDATA_OP_LOX10, 83)
ELF_RELOC(R_SPARC_GOTDATA_OP, 84)
+ELF_RELOC(R_SPARC_H34, 85)
+ELF_RELOC(R_SPARC_SIZE32, 86)
+ELF_RELOC(R_SPARC_SIZE64, 87)
+ELF_RELOC(R_SPARC_WDISP10, 88)
+ELF_RELOC(R_SPARC_JMP_IREL, 248)
+ELF_RELOC(R_SPARC_IRELATIVE, 249)
+ELF_RELOC(R_SPARC_GNU_VTINHERIT, 250)
+ELF_RELOC(R_SPARC_GNU_VTENTRY, 251)
+ELF_RELOC(R_SPARC_REV32, 252)
|
MaskRay
reviewed
May 3, 2025
alexrp
force-pushed
the
sparc-update-relocs
branch
from
22e4506 to
60eb632
Compare
|
(Still on a trip with limited computer access) We need a llvm-readobj test. You can git log how I update the ELF relocation types with accompanying test/tools/llvm-readobj tests. |
|
It seems like such a test was never added for SPARC. Would e.g. |
alexrp
force-pushed
the
sparc-update-relocs
branch
from
60eb632 to
3126e21
Compare
alexrp
changed the title
MaskRay
approved these changes
May 4, 2025
alexrp
referenced
this pull request
May 5, 2025
The simm13 format OR instruction should use one single fixup kind, while it currently uses a lot more, including %m44/%l44. This change refactors R_SPARC_H44/R_SPARC_M44/R_SPARC_M44 handling to remove fixup kinds and specifiers. We utilize the [0, FirstLiteralRelocationKind) MCFixupKind range to encode raw relocation types that may be resolved (see the MCAssembler.cpp change). The `evaluateAsRelocatableImpl` implementation resembles PPCMCExpr::evaluateAsRelocatableImpl.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…tags. (llvm#137916) Values sourced from binutils.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…tags. (llvm#137916) Values sourced from binutils.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…tags. (llvm#137916) Values sourced from binutils.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
…tags. (llvm#137916) Values sourced from binutils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values sourced from binutils.