Skip to content

[llvm] No DWARF CFI for UEFI #138602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

[llvm] No DWARF CFI for UEFI #138602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/Target/X86/X86FrameLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2431,7 +2431,8 @@ void X86FrameLowering::emitEpilogue(MachineFunction &MF,
uint64_t NumBytes = 0;

bool NeedsDwarfCFI = (!MF.getTarget().getTargetTriple().isOSDarwin() &&
!MF.getTarget().getTargetTriple().isOSWindows()) &&
!MF.getTarget().getTargetTriple().isOSWindows() &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test. You might check whether there is a test that covers isOSDarwin/isOSWindows

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'll look. Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI there are a couple of e2e tests that cover this change. One under review: https://github.com/llvm/llvm-project/pull/138362/files#diff-e47f971f8f461b56fd6688777c1e931fa02aa2e27cb6002f8575a1f9baa2dc26

Another one landed: https://github.com/llvm/llvm-project/pull/138361/files#diff-794c27548ad64f38994f367a0552e6b83511f1861924bd2cf42083aae690c569

But I'll continue to look if I can add a more targeted test.

!MF.getTarget().getTargetTriple().isUEFI()) &&
MF.needsFrameMoves();

Register ArgBaseReg;
Expand Down