IR: Remove redundant UseList check in addUse #138676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arsenm
requested review from
dexonsmith,
dtcxzyw,
efriedma-quic,
nikic and
teresajohnson
|
@llvm/pr-subscribers-llvm-ir Author: Matt Arsenault (arsenm) ChangesNot sure if this did anything for compile time or not. Full diff: https://github.com/llvm/llvm-project/pull/138676.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/Value.h b/llvm/include/llvm/IR/Value.h
index ae874304c4316..3f94081d7b844 100644
--- a/llvm/include/llvm/IR/Value.h
+++ b/llvm/include/llvm/IR/Value.h
@@ -509,7 +509,7 @@ class Value {
/// This method should only be used by the Use class.
void addUse(Use &U) {
- if (UseList || hasUseList())
+ if (hasUseList())
U.addToList(&UseList);
}
|
arsenm
force-pushed
the
users/arsenm/ir/reorder-constant-data-enum-values
branch
from
936319a to
5317c2e
Compare
arsenm
force-pushed
the
users/arsenm/ir/remove-redundant-null-uselist-check-addUse
branch
from
247bcd6 to
09e9b5d
Compare
arsenm
force-pushed
the
users/arsenm/ir/reorder-constant-data-enum-values
branch
from
5317c2e to
7c7350f
Compare
arsenm
force-pushed
the
users/arsenm/ir/remove-redundant-null-uselist-check-addUse
branch
from
09e9b5d to
53ee4a8
Compare
arsenm
force-pushed
the
users/arsenm/ir/reorder-constant-data-enum-values
branch
from
7c7350f to
010c0ad
Compare
arsenm
force-pushed
the
users/arsenm/ir/remove-redundant-null-uselist-check-addUse
branch
from
53ee4a8 to
dedd320
Compare
This was referenced May 10, 2025
Depends on the parent, plus was hoping to run this through compile time tracker |
CTMark: https://llvm-compile-time-tracker.com/compare.php?from=a861f50030a9dac28a35654506bb28d2bc239b56&to=a33632206ab5e08caf9e243009f5911400441d01&stat=instructions:u |
Surprised it's slightly worse |
|
I think this may have been noise. I reran this and there are no differences over the significance threshold: https://llvm-compile-time-tracker.com/compare.php?from=6c1bb48cc45396894597c8cb897c31205d1bdeb6&to=1837fe71fcfb4363fd2b66cdb9ff6a82b3f380fb&stat=instructions:u |
nikic
approved these changes
May 14, 2025
arsenm
force-pushed
the
users/arsenm/ir/reorder-constant-data-enum-values
branch
from
010c0ad to
dc6faab
Compare
Base automatically changed from
users/arsenm/ir/reorder-constant-data-enum-values
to
main
May 19, 2025 10:14
Not sure if this did anything for compile time or not.
arsenm
force-pushed
the
users/arsenm/ir/remove-redundant-null-uselist-check-addUse
branch
from
dedd320 to
1e68e5b
Compare
arsenm
deleted the
users/arsenm/ir/remove-redundant-null-uselist-check-addUse
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/15420 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this did anything for compile time or not.