Skip to content

[Github][CI] Make the new premerge system fail jobs on errors #139359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 26, 2025
Merged

[Github][CI] Make the new premerge system fail jobs on errors #139359

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0b14e2
[𝘀𝗽𝗿] changes to main this commit is based on
boomanaiden154 May 10, 2025
2b6ad96
[𝘀𝗽𝗿] initial version
boomanaiden154 May 10, 2025
a8fe91c
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 May 26, 2025
92a4aca
rebase
boomanaiden154 May 26, 2025
ec946e9
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 May 26, 2025
8ca90e1
rebase
boomanaiden154 May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/premerge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ on:
- closed
push:
branches:
- 'main'
- 'release/**'

concurrency:
Expand All @@ -43,9 +42,6 @@ jobs:
# Mark the job as a success even if the step fails so that people do
# not get notified while the new premerge pipeline is in an
# experimental state.
# TODO(boomanaiden154): Remove this once the pipeline is stable and we
# are ready for people to start recieving notifications.
continue-on-error: true
run: |
git config --global --add safe.directory '*'

Expand Down Expand Up @@ -110,9 +106,6 @@ jobs:
# Mark the job as a success even if the step fails so that people do
# not get notified while the new premerge pipeline is in an
# experimental state.
# TODO(boomanaiden154): Remove this once the pipeline is stable and we
# are ready for people to start recieving notifications.
continue-on-error: true
if: ${{ steps.vars.outputs.windows-projects != '' }}
shell: cmd
run: |
Expand Down
Loading