Skip to content

Fix references to required libraries when building LLVM with ASAN and MultiThreaded[Debug] on Windows #139657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgg5503
Copy link
Contributor

@dgg5503 dgg5503 commented May 13, 2025

After #81677, statically linking ASAN under Windows is no longer supported. Therefore, when using Clang built past 53a81d4 to build LLVM / Clang with -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded[Debug] -DLLVM_USE_SANITIZER=Address, a different set of dependent libraries must be linked. This is mentioned in the description of #81677 and also in https://devblogs.microsoft.com/cppblog/msvc-address-sanitizer-one-dll-for-all-runtime-configurations/.

@llvmbot llvmbot added the cmake Build system in general and CMake in particular label May 13, 2025
@dgg5503 dgg5503 requested review from barcharcraz and vitalybuka May 13, 2025 14:16
Copy link
Collaborator

@vitalybuka vitalybuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for @barcharcraz

@dgg5503
Copy link
Contributor Author

dgg5503 commented May 16, 2025

Ping @barcharcraz

1 similar comment
@dgg5503
Copy link
Contributor Author

dgg5503 commented May 21, 2025

Ping @barcharcraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants