-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[Github] Tweak the good-first-issue message not to require assignment. #139858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New contributors can just indicate that they are working on the issue without requesting assignment. That shouldd reduce the burden of assigned issues that are not actually being worked on, and new contributors waiting for a maintainer to asssign them the issue.
@llvm/pr-subscribers-github-workflow Author: cor3ntin (cor3ntin) ChangesNew contributors can just indicate that they are working on the issue without requesting assignment. That shouldd reduce the burden of assigned issues that are not actually being worked on, and new contributors waiting for a maintainer to asssign them the issue. Full diff: https://github.com/llvm/llvm-project/pull/139858.diff 1 Files Affected:
diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 6b2ed9759b099..9b2957ee56650 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -26,8 +26,8 @@
This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
-1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
-1. In the comments of this issue, request for it to be assigned to you, or just create a [pull request](https://github.com/llvm/llvm-project/pulls) after following the steps below. [Mention](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this issue in the description of the pull request.
+1. Check that no other contributor is working this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
+1. Leave a comment indicating that you are working on the issue, or just create a [pull request](https://github.com/llvm/llvm-project/pulls) after following the steps below. [Mention](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this issue in the description of the pull request.
1. Fix the issue locally.
1. [Run the test suite](https://llvm.org/docs/TestingGuide.html#unit-and-regression-tests) locally. Remember that the subdirectories under `test/` create fine-grained testing targets, so you can e.g. use `make check-clang-ast` to only run Clang's AST tests.
1. Create a Git commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this! I've found that this is quite successful in the FE. The assignment chases folks away, so someone that says "assign me" then disappears ends up discouraging contribution.
So I'm in favor, and hope that we're willing to accept this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes a lot of sense. This is probably one of the biggest issues I see with the good-first-issue label. I think this approach will address most of the problems, so I am in favor assuming others do not have major objections.
LGTM |
Co-authored-by: Danny Mösch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@tstellar You are happy with that? |
Feel free to leave post-commit reviews :) |
New contributors can just indicate that they are working on the issue without requesting assignment.
That shouldd reduce the burden of assigned issues that are not actually being worked on, and new contributors waiting for a maintainer to asssign them the issue.