Skip to content

[X86] Move X86ISD::FP_TO_SINT_SAT/FP_TO_UINT_SAT outside of the MEMORY_OPCODE enum block #140272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2025

Conversation

RKSimon
Copy link
Collaborator

@RKSimon RKSimon commented May 16, 2025

Move to closer to the other regular conversion opcodes

Fixes #140271

…Y_OPCODE enum block

Move to closer to the other regular conversion opcodes

Fixes llvm#140271
@llvmbot
Copy link
Member

llvmbot commented May 16, 2025

@llvm/pr-subscribers-backend-x86

Author: Simon Pilgrim (RKSimon)

Changes

Move to closer to the other regular conversion opcodes

Fixes #140271


Full diff: https://github.com/llvm/llvm-project/pull/140272.diff

1 Files Affected:

  • (modified) llvm/lib/Target/X86/X86ISelLowering.h (+4-4)
diff --git a/llvm/lib/Target/X86/X86ISelLowering.h b/llvm/lib/Target/X86/X86ISelLowering.h
index 662552a972249..00917115e9df2 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.h
+++ b/llvm/lib/Target/X86/X86ISelLowering.h
@@ -724,6 +724,10 @@ namespace llvm {
     MCVTSI2P,
     MCVTUI2P,
 
+    // Custom handling for FP_TO_xINT_SAT
+    FP_TO_SINT_SAT,
+    FP_TO_UINT_SAT,
+
     // Vector float to bfloat16.
     // Convert packed single data to packed BF16 data
     CVTNEPS2BF16,
@@ -917,10 +921,6 @@ namespace llvm {
     // Load x87 FPU environment from memory.
     FLDENVm,
 
-    // Custom handling for FP_TO_xINT_SAT
-    FP_TO_SINT_SAT,
-    FP_TO_UINT_SAT,
-
     /// This instruction implements FP_TO_SINT with the
     /// integer destination in memory and a FP reg source.  This corresponds
     /// to the X86::FIST*m instructions and the rounding mode change stuff. It

Copy link
Contributor

@phoebewang phoebewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RKSimon RKSimon merged commit ad31366 into llvm:main May 18, 2025
8 of 11 checks passed
@RKSimon RKSimon deleted the x86-fp2int-sat branch May 18, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[X86] X86ISD::FP_TO_SINT_SAT/FP_TO_UINT_SAT are incorrectly defined in the MEMORY_OPCODE block
3 participants