Skip to content

[mlir] Use llvm::all_of (NFC) #140464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 18, 2025

@llvm/pr-subscribers-mlir-gpu
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-flang-openmp

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/140464.diff

3 Files Affected:

  • (modified) mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp (+8-10)
  • (modified) mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp (+3-4)
  • (modified) mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp (+2-3)
diff --git a/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp b/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
index 6119097456d1f..7a0a7f86bc1e9 100644
--- a/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
+++ b/mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
@@ -115,16 +115,14 @@ void mlir::configureOpenMPToLLVMConversionLegality(
       >([&](Operation *op) {
     return typeConverter.isLegal(op->getOperandTypes()) &&
            typeConverter.isLegal(op->getResultTypes()) &&
-           std::all_of(op->getRegions().begin(), op->getRegions().end(),
-                       [&](Region &region) {
-                         return typeConverter.isLegal(&region);
-                       }) &&
-           std::all_of(op->getAttrs().begin(), op->getAttrs().end(),
-                       [&](NamedAttribute attr) {
-                         auto typeAttr = dyn_cast<TypeAttr>(attr.getValue());
-                         return !typeAttr ||
-                                typeConverter.isLegal(typeAttr.getValue());
-                       });
+           llvm::all_of(op->getRegions(),
+                        [&](Region &region) {
+                          return typeConverter.isLegal(&region);
+                        }) &&
+           llvm::all_of(op->getAttrs(), [&](NamedAttribute attr) {
+             auto typeAttr = dyn_cast<TypeAttr>(attr.getValue());
+             return !typeAttr || typeConverter.isLegal(typeAttr.getValue());
+           });
   });
 }
 
diff --git a/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp b/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp
index b906c727604dc..723b4d01186f9 100644
--- a/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp
+++ b/mlir/lib/Dialect/MemRef/Transforms/ExtractAddressComputations.cpp
@@ -251,10 +251,9 @@ struct LoadStoreLikeOpRewriter : public OpRewritePattern<LoadStoreLikeOp> {
     // to do.
     SmallVector<OpFoldResult> indices =
         getAsOpFoldResult(loadStoreLikeOp.getIndices());
-    if (std::all_of(indices.begin(), indices.end(),
-                    [](const OpFoldResult &opFold) {
-                      return isConstantIntValue(opFold, 0);
-                    })) {
+    if (llvm::all_of(indices, [](const OpFoldResult &opFold) {
+          return isConstantIntValue(opFold, 0);
+        })) {
       return rewriter.notifyMatchFailure(
           loadStoreLikeOp, "no computation to extract: offsets are 0s");
     }
diff --git a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
index c99e925a97633..0afc502c026f7 100644
--- a/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
+++ b/mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp
@@ -312,9 +312,8 @@ LogicalResult LoadNdOp::verify() {
     auto trans = getTranspose().value();
 
     // Make sure the transpose value is valid.
-    bool valid = std::all_of(trans.begin(), trans.end(), [&](int t) {
-      return t >= 0 && t < tdescTy.getRank();
-    });
+    bool valid = llvm::all_of(
+        trans, [&](int t) { return t >= 0 && t < tdescTy.getRank(); });
 
     if (valid)
       transpose(trans, tdescShape);

@kazutakahirata kazutakahirata merged commit 6d515ce into llvm:main May 19, 2025
17 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_range_llvm_all_of_mlir branch May 19, 2025 01:44
@hanhanW
Copy link
Contributor

hanhanW commented May 20, 2025

(sorry for the spam. I misread and I was confused. I deleted the old comment because it's too embarrassing. 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants