[CodeGen] Avoid MachineModuleInfo in MachineModuleSlotTracker

[optimisan]

In NPM, MMI is not used to store machine functions so we need to use the analysis manager here.

[optimisan]

• [CodeGen] Avoid MachineModuleInfo in MachineModuleSlotTracker #140530 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[arsenm]

In NPM, MMI is not used to store machine functions so we need to use the analysis manager here.

This sounds broken. MachineModuleInfo is supposed to merely be the map from Function to MachineFunction. The NewPM (and other PM-less uses) should still use it

[optimisan]

We moved from having a MF analysis (in legacy) to MMI to support Module passes in codegen pipeline.
In NPM we are moving back to MF analysis (in NPM) and this patch is to complete this.
I don't see any new developments in this area, so

In NPM, MMI is not used to store machine functions so we need to use the analysis manager here.

This sounds broken. MachineModuleInfo is supposed to merely be the map from Function to MachineFunction. The NewPM (and other PM-less uses) should still use it

is mostly contradicting #88610 (review): "Moving things out of MMI is good"

[arsenm]

#88610 (review)

At this point MachineModuleInfo is just about reduced to the minimal map of IR Function to MachineFunction, the extra state has been removed. MachineModuleAnalysis still just holds a reference to the owning MachineModuleInfo?

[arsenm]

Shouldn't need const_cast