Re-apply "[StaticDataLayout][PGO]Implement reader and writer change for data access profiles" #141275
+315
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the use-of-uninitialized-memory error (https://lab.llvm.org/buildbot/#/builders/94/builds/7373).
Tested: The error is reproduced with https://github.com/llvm/llvm-zorg/blob/main/zorg/buildbot/builders/sanitizers/buildbot_bootstrap_msan.sh without the fix, and test pass with the fix.
Original commit message:
#138170 introduces classes to operate on data access profiles. This change supports the read and write of
DataAccessProfData
in indexed format of MemProf (v4) as well as its the text (yaml) format.For indexed format:
std::unique_ptr<DataAccessProfData>
) the data access profiles, and gives a non-owned copy when it callswriteMemProf
.uint64_t
to record the byte offset of data access profiles. Thisuint64_t
field is zero if data access profile is not set (nullptr).DataAccessProfData
.For textual format:
099a0fa (by @snehasish) introduces v4 which contains CalleeGuids in CallSiteInfo, and this change changes the v4 format in place with data access profiles. The current plan is to bump the version and enable v4 profiles with both features, assuming waiting for this change won't delay the callsite change too long.