[clang-format] Add BreakBeforeInlineASMColon and BreakBeforeStructInitialization configurations #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2020 12:20
If ``true``, struct left brace will be placed after line breaks.
true:
struct new_struct struct_name =
{...};
false:
struct new_struct struct_name = {
...};
Signed-off-by: Anastasiia Lukianenko <[email protected]>
If ``true``, colons in ASM parameters will be placed after line breaks.
true:
asm volatile("loooooooooooooooooooooooooooooooooooooooooooooong",
:
: val);
false:
asm volatile("loooooooooooooooooooooooooooooooooooooooooooooong",
: : val);
Signed-off-by: Anastasiia Lukianenko <[email protected]>
|
This repository does not accept pull requests. Please follow http://llvm.org/docs/Contributing.html#how-to-submit-a-patch for contribution to LLVM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to use the clang-format approach as a base for Xen [1] style formatting.
During the state of testing clang-format with different configurations, we found that some points regarding the Xen coding style are not configurable. Therefore, we decided to add them to be able to make a choice in different cases.
[1] - https://xenproject.org/